Improve Pixel Templates Payload Inspector messages

[mmusich]

PR description:

Small technical update, in order not to forego the case in which a certain template payload has less entries than expected for phase-1 detector, but more than phase-0, which means certain DetIds were not populated.
The use-case is documented here.
I profit of this PR to add a missing include CondCore/SiPixelPlugins/interface/SiPixelPayloadInspectorHelper.h which prevents to use the file from other packages.

PR validation:

See e-mail thread at: https://hypernews.cern.ch/HyperNews/CMS/get/tk-alignment/1899.html

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.

[cmsbuild]

The code-checks are being triggered in jenkins.

[mmusich]

@cmsbuild please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30249/16146

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/SiPixelPlugins/interface/SiPixelPayloadInspectorHelper.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937
  • File CondCore/SiPixelPlugins/plugins/SiPixelTemplateDBObject_PayloadInspector.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30249/16146/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30249/16146/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30249/16147

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/SiPixelPlugins/interface/SiPixelPayloadInspectorHelper.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937
  • File CondCore/SiPixelPlugins/plugins/SiPixelTemplateDBObject_PayloadInspector.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiPixelPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7085/console Started: 2020/06/15 20:10

[cmsbuild]

+1
Tested at: e243154
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-224790/7085/summary.html
CMSSW: CMSSW_11_2_X_2020-06-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-224790/7085/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778757
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1