Add TEveGeoShape header

[mrodozov]

PR description:

Adds header for TEveGeoShape type after the yet another ROOT cleanup
to the files that uses the type.

PR validation:

Bulilds without complain from cmssw compilation

[cmsbuild]

The code-checks are being triggered in jenkins.

[mrodozov]

test parameters:

• pull_request = [11.2 ROOT master] Get latest commits  cmsdist#5952

[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30303/16266

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Fireworks/Calo/plugins/FWMETProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
  • File Fireworks/Calo/src/FWTauProxyBuilderBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
  • File Fireworks/Core/src/BuilderUtils.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Core/src/FW3DViewGeometry.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Core/src/FWEveOverlap.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Core/src/FWGeometry.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Core/src/FWGlimpseView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Core/src/FWRPZViewGeometry.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
  • File Fireworks/Core/src/FWViewGeometryList.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File Fireworks/Electrons/src/makeSuperCluster.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Muons/plugins/FWCSCSegmentProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Muons/plugins/FWDTSegmentProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Muons/plugins/FWGEMRecHitProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Muons/plugins/FWGEMSegmentProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Muons/plugins/FWME0RecHitProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Muons/plugins/FWME0SegmentProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Muons/plugins/FWRPCRecHitProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Muons/src/FWMuonBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
  • File Fireworks/Tracks/plugins/FWSiStripClusterProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Vertices/plugins/FWSecVertexProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Fireworks/Vertices/plugins/FWVertexProxyBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File SimDataFormats/TrackerDigiSimLink/interface/StripCompactDigiSimLinks.h modified in PR(s): Add missing include for std::vector #30293

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5952

• CMSSW_11_2_ROOT6_X_2020-06-18-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7199/console Started: 2020/06/19 13:27

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

Fireworks/Calo
Fireworks/Core
Fireworks/Electrons
Fireworks/Muons
Fireworks/Tracks
Fireworks/Vertices
SimDataFormats/TrackerDigiSimLink

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @alja can you please review it and eventually sign? Thanks.
@alja, @calderona, @makortel, @trocino, @abbiendi, @JanFSchulte, @jhgoh, @apsallid, @cericeci, @HuguesBrun, @Fedespring, @lecriste, @ebrondol, @rovere, @mtosi, @fabiocos, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[alja]

+1

[cmsbuild]

-1

Tested at: 5578c33

CMSSW: CMSSW_11_2_ROOT6_X_2020-06-18-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23d56d/7199/summary.html

I found follow errors while testing this PR

Failed tests: HeaderConsistency UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testDD4hepCompactView had ERRORS
---> test testDD4hepExpandedView had ERRORS
---> test testDD4hepFilteredView had ERRORS
---> test DetectorDescriptionDDCMSTestDriver had ERRORS
---> test GeometryDTGeometryBuilderTestDriver had ERRORS
---> test DD4hepGeometryTestDriver had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23d56d/7199/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778760
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[smuzaffar]

@civanch, @mdhildreth can you please sign this for simulation. It only adds a missing header of vector in one of simulation related file.

[civanch]

+1

hope, that unit tests will be fixed soon

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@silviodonato , can you please merge this for next IB so that we can update root for ROOT6 IBs.

[silviodonato]

+1