Fix Pythia8Interface adapted to pythia8 302 #30319

mkirsano · 2020-06-20T15:28:59Z

Fix of Pythia8Interface adapted to pythia8 302 integrated with #29995

PR description:

Addresses the issue #30234

PR validation:

Configuration from the issue #30234 and usual tests of Pythia8Interface

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-06-20T15:29:27Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-20T15:37:30Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16304

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16304/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16304/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16304/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16304/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-06-20T15:46:21Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-20T15:54:53Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16305

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16305/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16305/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-06-22T14:52:57Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-22T14:59:11Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16326

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16326/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16326/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-06-23T09:04:26Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-23T09:10:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30319/16348

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-23T09:11:11Z

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for master.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

mkirsano · 2020-06-23T09:53:12Z

+1

cmsbuild · 2020-06-23T09:53:30Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-22-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7273/console Started: 2020/06/23 11:54

cmsbuild · 2020-06-23T09:53:31Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2020-06-23T11:07:45Z

+1
Tested at: 7b07b42
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-292fd0/7273/summary.html
CMSSW: CMSSW_11_2_X_2020-06-22-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-23T11:07:48Z

Comparison job queued.

cmsbuild · 2020-06-23T13:27:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-292fd0/7273/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778757
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

silviodonato · 2020-06-23T17:00:17Z

@mkirsano please fill the PR description

silviodonato · 2020-06-23T19:31:40Z

+1

Fix Pythia8Interface adapted to pythia8 302

0f578ea

cmsbuild added this to the CMSSW_11_2_X milestone Jun 20, 2020

cmsbuild added code-checks-pending comparison-pending generators-pending orp-pending pending-signatures tests-pending labels Jun 20, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 20, 2020

Follow code-checks

d8c244d

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 20, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 20, 2020

Follow code-checks

ab05634

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 22, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 22, 2020

Follow code-checks

7b07b42

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 23, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 23, 2020

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Jun 23, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 23, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 23, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 23, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 23, 2020

cmsbuild merged commit c48b87a into cms-sw:master Jun 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Pythia8Interface adapted to pythia8 302 #30319

Fix Pythia8Interface adapted to pythia8 302 #30319

mkirsano commented Jun 20, 2020 •

edited

cmsbuild commented Jun 20, 2020

cmsbuild commented Jun 20, 2020

cmsbuild commented Jun 20, 2020

cmsbuild commented Jun 20, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

mkirsano commented Jun 23, 2020

cmsbuild commented Jun 23, 2020 •

edited

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

silviodonato commented Jun 23, 2020

silviodonato commented Jun 23, 2020

Fix Pythia8Interface adapted to pythia8 302 #30319

Fix Pythia8Interface adapted to pythia8 302 #30319

Conversation

mkirsano commented Jun 20, 2020 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 20, 2020

cmsbuild commented Jun 20, 2020

cmsbuild commented Jun 20, 2020

cmsbuild commented Jun 20, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

mkirsano commented Jun 23, 2020

cmsbuild commented Jun 23, 2020 • edited

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

silviodonato commented Jun 23, 2020

silviodonato commented Jun 23, 2020

mkirsano commented Jun 20, 2020 •

edited

cmsbuild commented Jun 23, 2020 •

edited