added esConsumes to modules in EventFilter/1GlobalTriggerRawToDigi #30345

JamminJones · 2020-06-23T17:57:05Z

PR description:

added esConsumes to 6 modules

PR validation:

the code compiles

cmsbuild · 2020-06-23T17:57:30Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-23T18:02:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30345/16365

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GTDigiToRaw.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GTEvmDigiToRaw.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GlobaTriggerEvmRawToDigi.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GlobaTriggerRawToDigi.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GlobaTriggerRecordProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GtTriggerMenuLiteProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936

cmsbuild · 2020-06-23T18:03:00Z

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

EventFilter/L1GlobalTriggerRawToDigi

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-06-23T19:51:42Z

This change was done under my supervision.

Dr15Jones · 2020-06-23T19:57:33Z

please test

cmsbuild · 2020-06-23T19:57:53Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7294/console Started: 2020/06/23 21:59

cmsbuild · 2020-06-23T21:05:28Z

-1

Tested at: 7d610e7

CMSSW: CMSSW_11_2_X_2020-06-23-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bff56f/7294/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Tue Jun 23 22:50:10 2020-date Tue Jun 23 22:47:26 2020 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Tue Jun 23 22:53:49 2020-date Tue Jun 23 22:47:56 2020 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Tue Jun 23 22:53:24 2020-date Tue Jun 23 22:48:31 2020 s - exit: 16640

cmsbuild · 2020-06-23T21:05:30Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-06-24T14:32:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30345/16388

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GTDigiToRaw.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GTEvmDigiToRaw.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GlobaTriggerEvmRawToDigi.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GlobaTriggerRawToDigi.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GlobaTriggerRecordProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/L1GlobalTriggerRawToDigi/src/L1GtTriggerMenuLiteProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936

cmsbuild · 2020-06-24T14:32:49Z

Pull request #30345 was updated. @cmsbuild, @rekovic, @benkrikler can you please check and sign again.

Dr15Jones · 2020-06-24T14:33:45Z

please test

cmsbuild · 2020-06-24T14:34:07Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-24-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7316/console Started: 2020/06/24 16:42

cmsbuild · 2020-06-24T15:55:55Z

+1
Tested at: 49fc68c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bff56f/7316/summary.html
CMSSW: CMSSW_11_2_X_2020-06-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-24T15:55:58Z

Comparison job queued.

cmsbuild · 2020-06-24T17:47:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bff56f/7316/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778915
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778864
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

Dr15Jones · 2020-07-06T14:14:17Z

ping

rekovic · 2020-07-07T13:13:48Z

+1

cmsbuild · 2020-07-07T13:14:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-07T20:01:44Z

+1

added esConsumes to modules in EventFilter/1GlobalTriggerRawToDigi

7d610e7

cmsbuild added this to the CMSSW_11_2_X milestone Jun 23, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Jun 23, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 23, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 23, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jun 23, 2020

fixed esConsumes to include BeginRun

a4ab755

cmsbuild added code-checks-pending comparison-pending and removed code-checks-approved comparison-notrun tests-rejected labels Jun 23, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 24, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 24, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 24, 2020

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jul 7, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 7, 2020

cmsbuild merged commit 058724a into cms-sw:master Jul 7, 2020

This was referenced Jul 8, 2020

Phase2-hgx252 Make the new algorithm for dd4hep #30593

Merged

Clean BuildFiles in reco plugins #30535

Merged

Use ONNXRuntime for ParticleNet inference #30599

Merged

JamminJones deleted the fixEventFilterL1GlobalTriggerRawToDigi branch July 27, 2020 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added esConsumes to modules in EventFilter/1GlobalTriggerRawToDigi #30345

added esConsumes to modules in EventFilter/1GlobalTriggerRawToDigi #30345

JamminJones commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

Dr15Jones commented Jun 23, 2020

Dr15Jones commented Jun 23, 2020

cmsbuild commented Jun 23, 2020 •

edited

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

Dr15Jones commented Jun 24, 2020

cmsbuild commented Jun 24, 2020 •

edited

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

Dr15Jones commented Jul 6, 2020

rekovic commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

silviodonato commented Jul 7, 2020

added esConsumes to modules in EventFilter/1GlobalTriggerRawToDigi #30345

added esConsumes to modules in EventFilter/1GlobalTriggerRawToDigi #30345

Conversation

JamminJones commented Jun 23, 2020

PR description:

PR validation:

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

Dr15Jones commented Jun 23, 2020

Dr15Jones commented Jun 23, 2020

cmsbuild commented Jun 23, 2020 • edited

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

Dr15Jones commented Jun 24, 2020

cmsbuild commented Jun 24, 2020 • edited

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

Dr15Jones commented Jul 6, 2020

rekovic commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

silviodonato commented Jul 7, 2020

cmsbuild commented Jun 23, 2020 •

edited

cmsbuild commented Jun 24, 2020 •

edited