added esConsumes to modules in L1Trigger/GlobalCaloTrigger

[JamminJones]

PR description:

added esConsumes to 3 modules

PR validation:

the code compiles

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30348/16370

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/GlobalCaloTrigger/plugins/L1GctEmulator.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File L1Trigger/GlobalCaloTrigger/plugins/L1GctPrintLuts.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File L1Trigger/GlobalCaloTrigger/plugins/L1GctValidation.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936

[cmsbuild]

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

L1Trigger/GlobalCaloTrigger

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

ping

[rekovic]

+1

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-06-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7750/console Started: 2020/07/07 18:07

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: c61e8a5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fa05b/7750/summary.html
CMSSW: CMSSW_11_2_X_2020-07-06-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fa05b/7750/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2787364
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2787308
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[silviodonato]

+1