Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30473

silviodonato · 2020-06-30T15:59:41Z

Revert of the revert "Run4-hgx247 Add some new features for HGCal" (#30323) except L1Trigger/Configuration/python/SimL1Emulator_cff.py
The first revert was #30458 .

rever change

cmsbuild · 2020-06-30T16:00:07Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-30T16:06:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30473/16632

This PR adds an extra 8KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/CaloTopology/interface/HGCalTopology.h modified in PR(s): Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423
- File Geometry/CaloTopology/src/HGCalTopology.cc modified in PR(s): Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423
- File Geometry/HGCalCommonData/interface/HGCalDDDConstants.h modified in PR(s): Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423
- File Geometry/HGCalCommonData/python/testHGCalV13XML_cfi.py modified in PR(s): Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423
- File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423, [RFC] Test clang-tidy --checks modernize-loop-convert #29935

cmsbuild · 2020-06-30T16:07:15Z

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Geometry/CaloTopology
Geometry/HGCalCommonData
Geometry/HGCalGeometry

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-06-30T16:20:52Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30470,cms-data/L1Trigger-L1THGCal#19

CMSSW_11_2_X_2020-06-30-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7537/console Started: 2020/06/30 18:36

cmsbuild · 2020-06-30T19:21:32Z

-1

Tested at: c81f28d

CMSSW: CMSSW_11_2_X_2020-06-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Add all direct deps to BuildFile for CondCore/Utilities #30378 @davidlange6: Add all direct deps to BuildFile for CondCore/Utilities
Add all direct deps to BuildFile for CondFormats/HLTObjects #30379 @davidlange6: Add all direct deps to BuildFile for CondFormats/HLTObjects
Add all direct deps to BuildFile for CondFormats/SiPixelObjects #30381 @davidlange6: Add all direct deps to BuildFile for CondFormats/SiPixelObjects
Add all direct deps to BuildFile for Alignment/CocoaFit #30461 @davidlange6: Add all direct deps to BuildFile for Alignment/CocoaFit
Add all direct deps to BuildFile for CondFormats/SiStripObjects #30382 @davidlange6: Add all direct deps to BuildFile for CondFormats/SiStripObjects

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7537/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7537/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7537/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
23234.0 step2

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Add all direct deps to BuildFile for CondCore/Utilities #30378 @davidlange6: Add all direct deps to BuildFile for CondCore/Utilities
Add all direct deps to BuildFile for CondFormats/HLTObjects #30379 @davidlange6: Add all direct deps to BuildFile for CondFormats/HLTObjects
Add all direct deps to BuildFile for CondFormats/SiPixelObjects #30381 @davidlange6: Add all direct deps to BuildFile for CondFormats/SiPixelObjects
Add all direct deps to BuildFile for Alignment/CocoaFit #30461 @davidlange6: Add all direct deps to BuildFile for Alignment/CocoaFit
Add all direct deps to BuildFile for CondFormats/SiStripObjects #30382 @davidlange6: Add all direct deps to BuildFile for CondFormats/SiStripObjects

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7537/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7537/git-merge-result

cmsbuild · 2020-06-30T19:21:39Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-07-01T16:12:18Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30470,cms-data/L1Trigger-L1THGCal#19

CMSSW_11_2_X_2020-06-30-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7563/console Started: 2020/07/01 18:14

cmsbuild · 2020-07-01T18:08:08Z

+1
Tested at: c81f28d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7563/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-01T18:08:15Z

Comparison job queued.

cmsbuild · 2020-07-01T19:59:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7563/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784069
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

silviodonato · 2020-07-01T20:45:25Z

merge

kpedro88 · 2020-07-01T20:46:35Z

+upgrade

cvuosalo · 2020-07-01T21:03:17Z

+1

cmsbuild · 2020-07-01T21:03:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Revert "Revert "Run4-hgx247 Add some new features for HGCal""

c81f28d

rever change

cmsbuild added this to the CMSSW_11_2_X milestone Jun 30, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jun 30, 2020

silviodonato mentioned this pull request Jun 30, 2020

Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30467

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 30, 2020

silviodonato mentioned this pull request Jun 30, 2020

[HGC trigger] Update mapping for V11 #30470

Merged

cmsbuild mentioned this pull request Jun 30, 2020

Update module mapping for V11 cms-data/L1Trigger-L1THGCal#19

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Jun 30, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jun 30, 2020

This was referenced Jul 1, 2020

New Package - Phase2 L1TTrackMatch #30363

Merged

Phase2-hgx250 Comparison of results from flat file and from insitu checks #30423

Merged

cmsbuild added tests-started and removed tests-rejected labels Jul 1, 2020

cmsbuild added comparison-available tests-approved and removed comparison-notrun tests-started labels Jul 1, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 1, 2020

cmsbuild merged commit 0ad2f1c into cms-sw:master Jul 1, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 1, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Jul 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30473

Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30473

silviodonato commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 •

edited

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jul 1, 2020 •

edited

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

silviodonato commented Jul 1, 2020

kpedro88 commented Jul 1, 2020

cvuosalo commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30473

Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30473

Conversation

silviodonato commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 • edited

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jul 1, 2020 • edited

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

silviodonato commented Jul 1, 2020

kpedro88 commented Jul 1, 2020

cvuosalo commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jun 30, 2020 •

edited

cmsbuild commented Jul 1, 2020 •

edited