Fix clang tidy mistakes

[fwyzard]

PR description:

Fix a couple of instances where the newly proposed clang-tidy checks would generate the wrong code.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[fwyzard]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30509/16710

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/CSCMonitorModule/plugins/CSCDQM_Collection.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-faster-string-find #29926
  • File RecoPPS/Local/plugins/TotemRPUVPatternFinder.cc modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, [RFC] Test clang-tidy --checks performance-for-range-copy #29927

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-02-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7620/console Started: 2020/07/02 19:15

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DQM/CSCMonitorModule
RecoPPS/Local

@perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @slava77 can you please review it and eventually sign? Thanks.
@ptcox, @barvic this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 042ab15
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-808603/7620/summary.html
CMSSW: CMSSW_11_2_X_2020-07-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-808603/7620/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2784120
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2784063
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[slava77]

+1

for #30509 042ab15

• technical

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1