Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST ONLY][Do not merge] New clang tidy checks #30508

Closed

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jul 2, 2020

PR description:

New clang tidy checks enabling, applied on cmssw, without test directory
The first commit is code-checks-all , the second will be the format.
PRs it sums up:
#29934
#29929
#29930
#29926
#29927
#29931

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2020

The code-checks are being triggered in jenkins.

@smuzaffar smuzaffar changed the title New clang tidy checks [TEST ONLY][Do not merge] New clang tidy checks Jul 2, 2020
@smuzaffar
Copy link
Contributor

@mrodozov , can you please provide the PR ref for each of these checks in the description? Just having the URL for PRs which @fwyzard made should be good enough

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2020

-code-checks

ERROR: Build errors found during clang-tidy run.

DQM/CSCMonitorModule/plugins/CSCDQM_Collection.cc:291:27: error: expected expression [clang-diagnostic-error]
        while (label.find(''') != std::string::npos) {
                          ^
Suppressed 1140 warnings (1134 in non-user code, 6 with check filters).
--
RecoPPS/Local/plugins/TotemRPUVPatternFinder.cc:211:13: error: binding reference of type 'RPData' to value of type 'const RPData' drops 'const' qualifier [clang-diagnostic-error]
    RPData &data = it.second;
            ^
Suppressed 1375 warnings (1373 in non-user code, 2 with check filters).
--
/cvmfs/cms-ib.cern.ch/nweek-02635/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-07-02-1100/src/DataFormats/Common/interface/Wrapper.h:92:80: error: no matching constructor for initialization of 'MkFitInputWrapper' [clang-diagnostic-error]
  Wrapper<T>::Wrapper(Emplace, Args&&... args) : WrapperBase(), present(true), obj(std::forward<Args>(args)...) {}
                                                                               ^
FWCore/Framework/interface/Event.h:448:43: note: in instantiation of function template specialization 'edm::Wrapper<MkFitInputWrapper>::Wrapper<MkFitHitIndexMap, std::vector<std::vector<mkfit::Hit, std::allocator<mkfit::Hit> >, std::allocator<std::vector<mkfit::Hit, std::allocator<mkfit::Hit> > > >, std::vector<mkfit::Track, std::allocator<mkfit::Track> >, mkfit::LayerNumberConverter &>' requested here
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

This was referenced Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment