Reduce boost dependency in FWCore/MessageService #30565
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30565/16802
|
|
A new Pull Request was created by @camolezi (Lucas Camolezi) for master. It involves the following packages: FWCore/MessageService @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins.
|
| @@ -29,7 +28,7 @@ namespace edm { | |||
|
|
|||
| // --- data: | |||
| edm::propagate_const<std::shared_ptr<ThreadQueue>> m_queue; | |||
| boost::thread m_scribeThread; | |||
| std::thread m_scribeThread; | |||
There was a problem hiding this comment.
@Dr15Jones This change is fine, right?
There was a problem hiding this comment.
I'm not certain we actually use this code.
There was a problem hiding this comment.
Do you mean the entire Presence system (a quick look supports such claim)?
It is probably easiest to let this change go in, and think of cleaning up what we don't use in the mean time (i.e. opening an issue)
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Replaced boost thread for std thread.
I believe in this case there is no need to use boost threading.
PR validation:
Passed on basic runTheMatrix test.
if this PR is a backport please specify the original PR and why you need to backport that PR:
@vgvassilev @davidlange6