Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix L1T bugs and add workflows [11_1_X] #30569

Merged
merged 6 commits into from Jul 9, 2020

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Jul 7, 2020

backport #30568

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_11_1_X.

It involves the following packages:

Configuration/PyReleaseValidation
L1Trigger/Configuration
L1Trigger/L1CaloTrigger
L1Trigger/Phase2L1ParticleFlow

@pgunnell, @benkrikler, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @rekovic can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 7, 2020

please test workflow 20634.99,23234.0,23234.1001,23234.1002,23234.21

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+1
Tested at: aac2cb5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b2484/7744/summary.html
CMSSW: CMSSW_11_1_X_2020-07-06-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison job queued.

@chayanit
Copy link

chayanit commented Jul 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b2484/7744/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9b2484/20634.99_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41PU_GenSimHLBeamSpotFull14+PREMIX_2026D41PU_PremixHLBeamSpotFull14PU_Premix+DigiFullTriggerPUPRMXCombined_2026D41PU+RecoFullGlobalPUPRMX_2026D41PU+HARVESTFullGlobalPU_2026D41PU
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9b2484/23234.1002_TTbar_14TeV+RecoFullGlobal_TestOldDigiProdLike_2026D49+MiniAODFullGlobal_TestOldDigiProdLike_2026D49
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9b2484/23234.21_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_ProdLike_2026D49+MiniAODFullGlobal_ProdLike_2026D49

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 8, 2020

+upgrade

@silviodonato
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants