fakeEmtfParams name update

[gekobs]

PR description:

Updating the import of fake Emtf params as PR#29767 updates the module fakeEmtfParams_cff.py to fakeEmtfParams_empty_cff.py .
This can be considered as a follow up of PR#29767.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30633/16902

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @gekobs (agzecchinelli) for master.

It involves the following packages:

L1TriggerConfig/L1TConfigProducers

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-09-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7858/console Started: 2020/07/10 15:28

[silviodonato]

urgent

[cmsbuild]

+1
Tested at: 9d0b08b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-686257/7858/summary.html
CMSSW: CMSSW_11_2_X_2020-07-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[jiafulow]

@gekobs Thanks for identifying the bug and fixing it. I'm sorry I didn't realize that the fakeEmtfParams_cff.py file was used in the L1 O2O. It was renamed to fakeEmtfParams_empty_cff.py, which caused this bug. The reason I renamed it was to distinguish it from the rest of the fakeEmtfParams_*_cff.py files that were added/modified in the particular PR.

The proposed fix looks good to me. If somehow there are more issues due to this file, it can also be simply reverted back to fakeEmtfParams_cff.py.

[gekobs]

@gekobs Thanks for identifying the bug and fixing it. I'm sorry I didn't realize that the fakeEmtfParams_cff.py file was used in the L1 O2O. It was renamed to fakeEmtfParams_empty_cff.py, which caused this bug. The reason I renamed it was to distinguish it from the rest of the fakeEmtfParams_*_cff.py files that were added/modified in the particular PR.

The proposed fix looks good to me. If somehow there are more issues due to this file, it can also be simply reverted back to fakeEmtfParams_cff.py.

Thanks for reviewing this. It was actually @hjkwon260 spotting this therefore shout to her

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-686257/7858/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2787429
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2787367
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[silviodonato]

merge