Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1TPF: Update single particle resolution in HGCal (backport) #30772

Merged
merged 1 commit into from Jul 17, 2020
Merged

L1TPF: Update single particle resolution in HGCal (backport) #30772

merged 1 commit into from Jul 17, 2020

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jul 17, 2020 •
edited by silviodonato

PR description:

backport of #30770

As described in https://hypernews.cern.ch/HyperNews/CMS/get/L1TriggerUpgrades/384/1/1/1/1/2/3/2.html ,
update also single particle resolution in the HGCal (was not in #30736)
The impact is most likely small, but it's updated for consistency with cms-data/L1Trigger-Phase2L1ParticleFlow#3

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Jul 17, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2020 •
edited

A new Pull Request was created by @rekovic for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/Phase2L1ParticleFlow

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Jul 17, 2020

please test

@rekovic
Copy link
Contributor Author

rekovic commented Jul 17, 2020

urgent

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@silviodonato
Copy link
Contributor

abort

@silviodonato
Copy link
Contributor

clone of #30770

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@silviodonato silviodonato reopened this Jul 17, 2020
@silviodonato
Copy link
Contributor

please test

@silviodonato
Copy link
Contributor

backport of #30770

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2020 •
edited

The tests are being triggered in jenkins.

@silviodonato silviodonato changed the title 112X L1T Phase2 ParticleFlow Update (backport) L1TPF: Update single particle resolution in HGCal (backport) Jul 17, 2020
@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b07d36c into cms-sw:CMSSW_11_1_X Jul 17, 2020
@cmsbuild
Copy link
Contributor

+1
Tested at: 5d51822
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64b123/8041/summary.html
CMSSW: CMSSW_11_1_X_2020-07-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64b123/8041/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780739
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport comparison-available l1-pending orp-approved pending-signatures tests-approved upgrade-pending urgent
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rekovic @cmsbuild @silviodonato @gpetruc