Fix bug introduced in the L1T PF code cleanup for release integration #30736

gpetruc · 2020-07-15T20:07:54Z

PR description:

Fix bug introduced in the code cleanup for release integration that was resulting garbage clusters in the barrel.
see https://hypernews.cern.ch/HyperNews/CMS/get/L1TriggerUpgrades/384/1.html

PR validation:

Plots of jet response and resolution in the barrel (ttbar, PU 200):

@rekovic

cmsbuild · 2020-07-15T20:08:17Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-15T20:13:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30736/17048

This PR adds an extra 16KB to repository

cmsbuild · 2020-07-15T20:13:37Z

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

L1Trigger/Phase2L1ParticleFlow

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2020-07-15T20:16:22Z

@gpetruc the second and third links in the PR description point to the same page

kpedro88 · 2020-07-15T20:16:38Z

please test

cmsbuild · 2020-07-15T20:16:44Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-14-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7986/console Started: 2020/07/15 22:20

gpetruc · 2020-07-15T20:17:30Z

@gpetruc the second and third links in the PR description point to the same page

sorry, copy-paste mistake. Fixed now

cmsbuild · 2020-07-15T21:31:05Z

+1
Tested at: 6a233a7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4badb5/7986/summary.html
CMSSW: CMSSW_11_2_X_2020-07-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Remove further unused classes from DataFormats/GEMDigi #30609 @watson-ij: Remove further unused classes from DataFormats/GEMDigi
Force the definition of the USEHYBRID preprocessor symbol #30683 @fwyzard: Force the definition of the USEHYBRID preprocessor symbol
added esConsumes to modules in RecoEgamma/EgammaPhotonProducers #30668 @JamminJones: added esConsumes to modules in RecoEgamma/EgammaPhotonProducers
added esConsumes to modules in RecoMuon/MuonSeedGenerator #30687 @JamminJones: added esConsumes to modules in RecoMuon/MuonSeedGenerator

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4badb5/7986/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4badb5/7986/git-merge-result

cmsbuild · 2020-07-15T21:31:08Z

Comparison job queued.

cmsbuild · 2020-07-16T03:01:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4badb5/7986/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2612943
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2612894
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 146 log files, 17 edm output root files, 35 DQM output files

fwyzard · 2020-07-16T06:06:12Z

@gpetruc thanks for the fix !

I've made a backport to 11.1.x in #30741 .

cmsbuild · 2020-07-16T15:50:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30736/17076

This PR adds an extra 20KB to repository

cmsbuild · 2020-07-16T15:50:35Z

Pull request #30736 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again.

fwyzard · 2020-07-16T16:15:29Z

Add to #30741 as well.

silviodonato · 2020-07-16T18:46:14Z

please test

silviodonato · 2020-07-16T18:46:26Z

urgent

cmsbuild · 2020-07-16T18:46:33Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-16-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8021/console Started: 2020/07/16 20:46

gpetruc · 2020-07-16T19:43:40Z

While this is all in terms of bugfixes, performance-wise I have also an update of the calibrations in gpetruc/cmssw@Fix_L1PF-from-CMSSW_11_2_X...gpetruc:UpdateCalib-CMSSW_11_2_X + cms-data/L1Trigger-Phase2L1ParticleFlow#3

A longer report is in
https://hypernews.cern.ch/HyperNews/CMS/get/L1TriggerUpgrades/384/1/1/1/1/2/3/2.html

cmsbuild · 2020-07-16T19:51:36Z

+1
Tested at: f352791
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4badb5/8021/summary.html
CMSSW: CMSSW_11_2_X_2020-07-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-16T19:51:38Z

Comparison job queued.

silviodonato · 2020-07-16T20:43:28Z

merge

cmsbuild · 2020-07-16T21:38:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4badb5/8021/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2612943
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2612894
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 146 log files, 17 edm output root files, 35 DQM output files

rekovic · 2020-07-17T07:04:52Z

+1

Fix bug introduced in the code cleanup for release integration

6a233a7

cmsbuild added this to the CMSSW_11_2_X milestone Jul 15, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jul 15, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 15, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 15, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 15, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 16, 2020

fwyzard mentioned this pull request Jul 16, 2020

Fix bug introduced in the L1T PF code cleanup for release integration (11.1.x) #30741

Merged

Fix ASAN issue cms-sw#30676

85df523

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 16, 2020

cmsbuild added the urgent label Jul 16, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 16, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 16, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 16, 2020

cmsbuild merged commit 4047512 into cms-sw:master Jul 16, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 16, 2020

gpetruc mentioned this pull request Jul 17, 2020

L1TPF: Update single particle resolution in HGCal #30770

Merged

cmsbuild added l1-approved and removed l1-pending labels Jul 17, 2020

rekovic mentioned this pull request Jul 17, 2020

L1TPF: Update single particle resolution in HGCal (backport) #30772

Merged

kpedro88 mentioned this pull request Sep 3, 2020

ASAN problem found in L1TPFCaloProducer #30583

Closed

gpetruc deleted the Fix_L1PF-from-CMSSW_11_2_X branch March 8, 2021 09:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug introduced in the L1T PF code cleanup for release integration #30736

Fix bug introduced in the L1T PF code cleanup for release integration #30736

gpetruc commented Jul 15, 2020 •

edited

Loading

cmsbuild commented Jul 15, 2020

cmsbuild commented Jul 15, 2020

cmsbuild commented Jul 15, 2020

kpedro88 commented Jul 15, 2020

kpedro88 commented Jul 15, 2020

cmsbuild commented Jul 15, 2020 •

edited

Loading

gpetruc commented Jul 15, 2020

cmsbuild commented Jul 15, 2020

cmsbuild commented Jul 15, 2020

cmsbuild commented Jul 16, 2020

fwyzard commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

fwyzard commented Jul 16, 2020

silviodonato commented Jul 16, 2020

silviodonato commented Jul 16, 2020

cmsbuild commented Jul 16, 2020 •

edited

Loading

gpetruc commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

silviodonato commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

rekovic commented Jul 17, 2020

Fix bug introduced in the L1T PF code cleanup for release integration #30736

Fix bug introduced in the L1T PF code cleanup for release integration #30736

Conversation

gpetruc commented Jul 15, 2020 • edited Loading

PR description:

PR validation:

cmsbuild commented Jul 15, 2020

cmsbuild commented Jul 15, 2020

cmsbuild commented Jul 15, 2020

kpedro88 commented Jul 15, 2020

kpedro88 commented Jul 15, 2020

cmsbuild commented Jul 15, 2020 • edited Loading

gpetruc commented Jul 15, 2020

cmsbuild commented Jul 15, 2020

cmsbuild commented Jul 15, 2020

cmsbuild commented Jul 16, 2020

fwyzard commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

fwyzard commented Jul 16, 2020

silviodonato commented Jul 16, 2020

silviodonato commented Jul 16, 2020

cmsbuild commented Jul 16, 2020 • edited Loading

gpetruc commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

silviodonato commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

rekovic commented Jul 17, 2020

gpetruc commented Jul 15, 2020 •

edited

Loading

cmsbuild commented Jul 15, 2020 •

edited

Loading

cmsbuild commented Jul 16, 2020 •

edited

Loading