New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move dictionaries for TrackingParticle and TrajectoryStateOnSurface to proper package #30848
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30848/17198
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Alignment/LaserAlignment @perrotta, @civanch, @slava77, @christopheralanwest, @mdhildreth, @cmsbuild, @tocheng, @tlampen, @jpata, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Indeed, the PR has nothing to do with conditions, rather alignment...
On Jul 27, 2020, at 3:20 PM, christopheralanwest <notifications@github.com<mailto:notifications@github.com>> wrote:
+1
* In response to #30848 (comment)<#30848 (comment)>, the statement persistent="false" is not used by the condition DB, which ignores the ROOT dictionary.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#30848 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ7N4DCARDPPJ47Q7X3R5V5JHANCNFSM4PDVCYAQ>.
|
These misplaced dictionaries cause runtime errors in the modules IB.
I made the vector<vector> transient to match other dictionaries involving this class. If that is not proper, then more significant changes are needed to CMSSW.