Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update centrality table for 2018 and 2021 heavy ion MC #30930

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR updates the centrality table for 2018 and "2021" heavy ion MC. An update to the data GT will be necessary at some point in the future, prior to the re-miniAOD of the HI data, but we will wait until the release and strategy for that re-miniAOD is available prior to performing that update. This is the plan that was agreed upon with HI experts in the AlCaDB meeting of July 27, 2020.

The GT diffs are as follows:

2018 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HI_v1/112X_upgrade2018_realistic_HI_v2

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_HI_v5/112X_mcRun3_2021_realistic_HI_v6

Attn: @mandrenguyen

PR validation:

Please see the presentations at the July 27, 2020 AlCa/DB meeting for details of the validation. In addition, a technical test was performed:

runTheMatrix.py -l limited,159.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport but may later be backported, depending upon in which release the re-miniAOD will be performed.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 159.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30930/17337

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2020

The tests are being triggered in jenkins.
Test Parameters:

@mandrenguyen
Copy link
Contributor

For info, no change is expected from this GT update, which adds tags that are no yet consumed by any workflow.
A subsequent PR will activate in the HI miniAOD worklow the module RecoHI/HiCentralityAlgos/python/CentralityBin_cfi.py, which consumes the tags that are updated in this PR.

@cmsbuild
Copy link
Contributor

+1
Tested at: 7ce8966
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1599a0/8323/summary.html
CMSSW: CMSSW_11_2_X_2020-07-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1599a0/8323/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1599a0/159.0_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RECOHI2021PPRECO+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525444
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525396
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8d03f36 into cms-sw:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants