Online BeamSpot ESProducer for Run3 workflow

[gennai]

PR description:

This is a cleanup version of a past PR #30591, introducing a new ESProducer to make a beamspot transient record to replace the old way (Run3) to access beamspot position at HLT

PR validation:

I have run the RecoVertex/BeamSpotProducer/test/readOnlineBeamSpotFromDB.py to test the ESProducer is working as expected. Another producer and a Analyzer have been added for further checks and future developments.

A Backporting to 11_1_X for the next MWGR (September) will be needed

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30965/17399

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoVertex/BeamSpotProducer/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30965/17399/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30965/17399/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30965/17400

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoVertex/BeamSpotProducer/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

[cmsbuild]

A new Pull Request was created by @gennai (simone gennai) for master.

It involves the following packages:

CondFormats/DataRecord
RecoVertex/BeamSpotProducer

@perrotta, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @jpata, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @ebrondol, @rovere, @mmusich, @mtosi, @dgulhan, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8418/console Started: 2020/07/30 12:48

[cmsbuild]

+1
Tested at: d093bd5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9101c/8418/summary.html
CMSSW: CMSSW_11_2_X_2020-07-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

[jpata]

Thank you - from my side this should be approved today.

[jpata]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-02-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8504/console Started: 2020/08/03 14:24

[cmsbuild]

+1
Tested at: 851cd62
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9101c/8504/summary.html
CMSSW: CMSSW_11_2_X_2020-08-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9101c/8504/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525448
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2525400
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[jpata]

+1

• tests pass with no difference, as expected
• adds a new OnlineBeamSpotESProducer and OfflineToTransientBeamSpotESProducer, with a corresponding test analyzer
• PR description is in line with the changes

[ggovi]

+1

[silviodonato]

do you have any comments @cms-sw/alca-l2 ?

[silviodonato]

merge
@cms-sw/alca-l2 please have a look when you have time

[tlampen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.