Conditions needed to introduce pedestal correlation coefficient for HB and HE channels and update pedestal widths for 2023/2024 #30999

christopheralanwest · 2020-07-31T03:39:35Z

PR description:

This PR updates the HcalSiPMParametersRcd tag for Run-3 MC scenarios to introduce a pedestal correlation coefficient for adjacent time slices for HB and HE channels. The motivation and impact on the HBHE reconstruction are given in presentation by Taeun Kwon. A separate, currently unused field in HcalSiPMParametersRcd is used to implement these changes but the corresponding code changes have not been made. Therefore, at this point, no changes are expected in standard workflows.

In addition, the HCAL pedestal widths are updated for 2023 and 2024 scenarios, following the request in the AlCaDB HN.

The global tag diffs are as follows:

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_design_v5/112X_mcRun3_2021_design_v6

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_v5/112X_mcRun3_2021_realistic_v6

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021cosmics_realistic_deco_v5/112X_mcRun3_2021cosmics_realistic_deco_v6

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_HI_v6/112X_mcRun3_2021_realistic_HI_v7

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2023_realistic_v4/112X_mcRun3_2023_realistic_v6

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2024_realistic_v4/112X_mcRun3_2024_realistic_v6

PR validation:

See the AlCa HN thread and references therein for details. In addition, a technical test was performed: runTheMatrix.py -l limited,12024.0,7.23,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and should not be backported.

…or HB and HE channels

cmsbuild · 2020-07-31T03:39:59Z

The code-checks are being triggered in jenkins.

christopheralanwest · 2020-07-31T03:43:04Z

test parameters
workflow = 12024.0,7.23,12834.0

cmsbuild · 2020-07-31T03:46:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30999/17453

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): Update HLT jet energy corrections in offline data GTs #30984

cmsbuild · 2020-07-31T03:46:25Z

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

christopheralanwest · 2020-07-31T03:50:54Z

please test

cmsbuild · 2020-07-31T03:51:12Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 12024.0,7.23,12834.0
CMSSW_11_2_X_2020-07-30-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8455/console Started: 2020/07/31 05:55

cmsbuild · 2020-07-31T05:22:53Z

+1
Tested at: cbb887d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c0e7f/8455/summary.html
CMSSW: CMSSW_11_2_X_2020-07-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-31T05:22:56Z

Comparison job queued.

cmsbuild · 2020-07-31T07:52:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c0e7f/8455/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7c0e7f/12024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021Design_GenSimFull+DigiFull_2021Design+RecoFull_2021Design+HARVESTFull_2021Design
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7c0e7f/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2553 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525444
DQMHistoTests: Total failures: 61231
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2464166
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

abdoulline · 2020-07-31T09:02:10Z

We don't expect any changes at this step, as the code, which is supposed to active correlation factors in MAHI fit (local HCAL reco) is not yet submitted....
To be clarified.

abdoulline · 2020-07-31T10:16:18Z

I see now: not only noise corr.factors added (wrt baseline), but also DarkCurrent (DC) values changed...
(while effective peds and ped.widths stay unchanged).
I've initiated discussion within HCAL DPG.

cmsbuild · 2020-08-01T21:07:46Z

Pull request #30999 was updated. @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please check and sign again.

christopheralanwest · 2020-08-01T21:09:30Z

please test

cmsbuild · 2020-08-01T21:09:51Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 12024.0,7.23,12834.0
CMSSW_11_2_X_2020-08-01-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8495/console Started: 2020/08/02 00:07

cmsbuild · 2020-08-01T23:33:20Z

+1
Tested at: 4171dd7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c0e7f/8495/summary.html
CMSSW: CMSSW_11_2_X_2020-08-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-01T23:33:23Z

Comparison job queued.

cmsbuild · 2020-08-02T01:48:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c0e7f/8495/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7c0e7f/12024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021Design_GenSimFull+DigiFull_2021Design+RecoFull_2021Design+HARVESTFull_2021Design
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7c0e7f/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2463 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525448
DQMHistoTests: Total failures: 55163
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2470238
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

abdoulline · 2020-08-03T10:16:21Z

Tags-content-wise, this is what HCAL DPG asked for...

christopheralanwest · 2020-08-03T12:06:49Z

+1

cmsbuild · 2020-08-03T12:07:13Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Introduce pedestal correlation coefficient for adjacent time slices f…

cbb887d

…or HB and HE channels

cmsbuild added this to the CMSSW_11_2_X milestone Jul 31, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Jul 31, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 31, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 31, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 31, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 31, 2020

Update HCAL pedestal widths for end of run 3 scenarios

4171dd7

christopheralanwest changed the title ~~Conditions needed to introduce pedestal correlation coefficient for HB and HE channels~~ Conditions needed to introduce pedestal correlation coefficient for HB and HE channels and update pedestal widths for 2023/2024 Aug 1, 2020

cmsbuild removed the code-checks-approved label Aug 1, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 1, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 2, 2020

abdoulline mentioned this pull request Aug 2, 2020

HCAL MC: adding pulse shape 208 for signal reconstruction #31014

Merged

cmsbuild mentioned this pull request Aug 2, 2020

Introduce Run 3 cosmics workflow using express GT #31020

Merged

cmsbuild added alca-approved fully-signed orp-approved and removed alca-pending pending-signatures orp-pending labels Aug 3, 2020

cmsbuild merged commit e1d7658 into cms-sw:master Aug 3, 2020

cmsbuild added orp-pending and removed orp-approved labels Aug 3, 2020

This was referenced Aug 3, 2020

Don't use an uninitialized edm::Hande in GEDPhotonProducer #31029

Merged

Throw if dereference an unset edm::Handle #30928

Merged

Don't use uninitialized edm::Handle in TrackstersProducer #31031

Merged

TaeunKwon mentioned this pull request Aug 5, 2020

code updates to add a noise correlation factor between adjacent time slices for HB and HE channels #31064

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conditions needed to introduce pedestal correlation coefficient for HB and HE channels and update pedestal widths for 2023/2024 #30999

Conditions needed to introduce pedestal correlation coefficient for HB and HE channels and update pedestal widths for 2023/2024 #30999

christopheralanwest commented Jul 31, 2020 •

edited

cmsbuild commented Jul 31, 2020

christopheralanwest commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

christopheralanwest commented Jul 31, 2020

cmsbuild commented Jul 31, 2020 •

edited

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

abdoulline commented Jul 31, 2020

abdoulline commented Jul 31, 2020

cmsbuild commented Aug 1, 2020

christopheralanwest commented Aug 1, 2020

cmsbuild commented Aug 1, 2020 •

edited

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 2, 2020

abdoulline commented Aug 3, 2020

christopheralanwest commented Aug 3, 2020

cmsbuild commented Aug 3, 2020

Conditions needed to introduce pedestal correlation coefficient for HB and HE channels and update pedestal widths for 2023/2024 #30999

Conditions needed to introduce pedestal correlation coefficient for HB and HE channels and update pedestal widths for 2023/2024 #30999

Conversation

christopheralanwest commented Jul 31, 2020 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 31, 2020

christopheralanwest commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

christopheralanwest commented Jul 31, 2020

cmsbuild commented Jul 31, 2020 • edited

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

abdoulline commented Jul 31, 2020

abdoulline commented Jul 31, 2020

cmsbuild commented Aug 1, 2020

christopheralanwest commented Aug 1, 2020

cmsbuild commented Aug 1, 2020 • edited

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 2, 2020

abdoulline commented Aug 3, 2020

christopheralanwest commented Aug 3, 2020

cmsbuild commented Aug 3, 2020

christopheralanwest commented Jul 31, 2020 •

edited

cmsbuild commented Jul 31, 2020 •

edited

cmsbuild commented Aug 1, 2020 •

edited