Fix to enable hpsPFTauDiscriminationByDeadECALElectronRejection in run2 reminiAODs (10_6_X)

[mbluj]

PR description:

Changes to fix the 10_6_X-related part of #31015 issue:

• Move era-dependent modification of the anti-electron-in-deadECal tauID from miniAOD to the HPS PFTau master configuration;
• Run such a modified tauID as part of the makePatTausTask within miniAOD sequence rather than its copy.

Introduced changes modify a bit logic of python configurations, but are expected to not change outputs.

PR validation:

Validated with configuration produced with the following cmsDriver command (with and without run2_miniAOD_devel era):

cmsDriver miniAOD2016 --filein /store/relval/CMSSW_10_6_12/RelValZTT_13UP16/AODSIM/PU25ns_106X_mcRun2_asymptotic_v13_hltul16_postVFP-v1/20000/157664D1-7172-C346-A158-010C1A5FEEFC.root file:MiniAOD2016.root --mc --eventcontent MINIAODSIM --runUnscheduled --datatier MINIAODSIM --conditions auto:run2_mc --step PAT --nThreads 4 --geometry DB:Extended --scenario pp --era Run2_2016,run2_miniAOD_devel -n -1 --no_exec

[cmsbuild]

A new Pull Request was created by @mbluj for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoTauTag/Configuration

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix to enable hpsPFTauDiscriminationByDeadECALElectronRejection in run2 reminiAODs #31047

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_6_X_2020-08-03-2300/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8549/console Started: 2020/08/04 14:23

[cmsbuild]

+1
Tested at: 1f08b68
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c72119/8549/summary.html
CMSSW: CMSSW_10_6_X_2020-08-03-2300
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c72119/8549/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214618
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214283
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 14 edm output root files, 34 DQM output files

[santocch]

+1

[slava77]

There is a merge conflict in this PR, apparently after merging of #31072.
Now that #31072 is in, it is also more appropriate to use run2_miniAOD_UL for this PR .

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_6_X_2020-08-11-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8707/console Started: 2020/08/11 18:33

[cmsbuild]

+1
Tested at: 557f20e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c72119/8707/summary.html
CMSSW: CMSSW_10_6_X_2020-08-11-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c72119/8707/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214618
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214282
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 14 edm output root files, 34 DQM output files

[slava77]

backport of #31047
... kind of

[slava77]

+1

for #31044 557f20e

• code changes are in line with the PR description and the follow up review
  • this is a technical update for the 10_6_X branch of what was previously done with a cloned "*ForMiniAOD" ID module. So, no differences in the final outputs are expected.
  • the backport part of Fix to enable hpsPFTauDiscriminationByDeadECALElectronRejection in run2 reminiAODs #31047 is to bring the modifications more in sync with the master and use the "native" hpsPFTauDiscriminationByDeadECALElectronRejection ID module
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[slava77]

@silviodonato @qliphy
can this be merged soon, so that #31065 can follow separately?
otherwise, it may become more practical to "-1" here and advance to #31065 , which currently includes this PR as a multi-feature backport.

Please check.
Thank you.

[qliphy]

+1

[slava77]

+1

this will need an explicit "merge" message, since the analysis signature can be bypassed, at least in this case (previously signed)

[silviodonato]

merge

[santocch]

+1

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.