CCLUT quality control and preliminary quality definition for GEM-CSC stubs (CCLUT-6)

[dildick]

PR description:

• I updated the CLCT data word. The 3-bit Run-3 pattern number and 4-bit slope (as calculated from the 12-bit comparator code and one of 5 patterns) are assigned in the pattern_ member. In addition, the Run-2 pattern number will be stored in pattern_ . For Run-3 scenarios, this Run-2 pattern is but an approximation. The idea is to continue sending LCTs with Run-2 patterns to the EMTF/OMTF to facilitate integration and training/testing of new algorithms for prompt and displaced muons. LCTs in real data will not contain the approximate Run-2 pattern number. In due time, the simulation should also only send the actual Run-3 pattern number.
• The CSCLCTTools file was replaced by class LCTQualityControl to check for valid stubs
• Preliminary LCT quality definitions were added for Run-3 CSC-only stubs and Run-3 GEM-CSC stubs
• The redundant variables dynamic_state_machine_zone and useOldLCTDataFormat_ have been removed. The former parameter was made redundant in Various improvements to CSC local trigger emulator #25165. The latter is superseded by use_run3_patterns_

PR validation:

Tested in CMSSW_11_2_X_2020-08-06-1100 on /RelValSingleMuFlatPt2To100/CMSSW_11_0_0-PU25ns_110X_mcRun4_realistic_v3_2026D49PU200-v1/GEN-SIM-DIGI-RAW and in CMSSW_11_2_0_pre3 on /RelValSingleMuPt10/CMSSW_11_0_0-110X_mcRun4_realistic_v2_2026D49noPU-v1/GEN-SIM-DIGI-RAW

Results shown here: https://indico.cern.ch/event/947218/contributions/3980597/attachments/2089339/3510511/CSCPositionResolutionNewPatterns_SD_20200819.pdf

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

FYI @tahuang1991

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31086/17624

• This PR adds an extra 84KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31086/17626

• This PR adds an extra 84KB to repository

[cmsbuild]

Pull request #31086 was updated. @cmsbuild, @rekovic, @benkrikler, @civanch, @mdhildreth can you please check and sign again.

[cmsbuild]

The code-checks are being triggered in jenkins.

[dildick]

It probably would be a good idea to merge CSCLCTTools and all checkValid functions in 3 different classes into a single CSCQualityControl class.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31086/17638

• This PR adds an extra 88KB to repository

[cmsbuild]

Pull request #31086 was updated. @cmsbuild, @rekovic, @benkrikler, @civanch, @mdhildreth can you please check and sign again.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #31086 was updated. @cmsbuild, @rekovic, @benkrikler, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-20-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8837/console Started: 2020/08/20 14:34

[cmsbuild]

+1
Tested at: f570d2f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea31f2/8837/summary.html
CMSSW: CMSSW_11_2_X_2020-08-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea31f2/8837/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2608222
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2608199
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[civanch]

+1

[silviodonato]

kind reminder @cms-sw/l1-l2

[rekovic]

@dildick The performance in PU0 is slightly improved, so good. Please let us know of the performance with PU200 when available.

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[dildick]

@rekovic My most recent presentation with LCT efficiency at PU200 is this one https://indico.cern.ch/event/946435/contributions/3977016/attachments/2087496/3507142/CSCTP_Eff_SD_20200804.pdf. See page 7-8. Efficiency of Run-3 patterns vs Run-1/2 patterns at PU0 can be found in this recent presentation https://indico.cern.ch/event/947218/contributions/3980597/attachments/2089339/3510511/CSCPositionResolutionNewPatterns_SD_20200819.pdf (CSC Weekly Meeting).

[qliphy]

+1

[qliphy]

+1