Various improvements to CSC local trigger emulator

[dildick]

This PR is the last one in a series to improve the CSC local trigger emulator. Follow up of #24422. It is based on the results of 2018 pp collision data vs emulator studies. The studies were carried out during the Summer and Fall of 2018. The proposed changes improve the agreement between the CSC DAQ data and the emulator in CMSSW.

Supporting material with plots can be found in the slides below:

• https://indico.cern.ch/event/769093/contributions/3195866/attachments/1744999/2824740/TaoOTMB_fw_20181023v3.pdf
• https://indico.cern.ch/event/756056/contributions/3133821/attachments/1748087/2834606/TaoOTMB_fw_20181106v2.pdf

List of all changes:

CSCBaseboard:

• All CSC processors and TMBs inherit from the CSCBaseboard from now on.

ALCT processor:

• During the study of data and emulation comparison, small disagreement between data and emulation was found and a few modifications were committed to improve ALCT processor. The proposed changes allow re-triggering on one wiregroup in some dead time after earlier ALCT is built on this wiregroup. The ALCT processor before this commit would prohibit the wiregroup from triggering in one event once the first ALCT is found on the wiregroup. However, in firmware, the wiregroup with ALCT is only dead for a few BX (~6BX) before it is triggered by next muon.
  To make emulator in ALCT part consistent with firmware, the change is to allow re-triggering on same wiregroup in 6BX after the earlier ALCT on the wiregroup.
• The implementation of ghost cancellation logic is also changed to accommodate the re-triggering change while the idea of ghost cancellation logic is kept the same.
• CSC upgrade algorithms are now stored in a class CSCUpgradeAnodeLCTProcessor, which inherits from CSCAnodeLCTProcessor

CLCT processor:

• localized dead time zoning was moved to the pre-trigger level.
• In addition, the dynamic dead time zoning option was taken out of the Run-3 configuration as it is currently not implemented yet.
• CSC upgrade algorithms are now stored in a class CSCUpgradeCathodeLCTProcessor, which inherits from CSCCathodeLCTProcessor

Trigger motherboard:

• OTMBs for ME3/1 and ME4/1 now also includes ME2/1 (without GEMs). This is necessary as some of the CSC OTMB upgrade planned for LS3 will be done during Run-3 which would allow running the upgrade algorithm without GE2/1.

CSCTriggerPrimitivesReader

• lot of updates for better data vs emulator studies

@tahuang1991 @ptcox @lpernie

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25165/7165

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25165/7165/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25165/7165/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25165/7166

[cmsbuild]

Pull request #25165 was updated. @nsmith-, @rekovic, @cmsbuild, @thomreis can you please check and sign again.

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31839/console Started: 2018/11/26 11:09

[cmsbuild]

+1
Tested at: d4bc574
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25165/31839/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25165/31839/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3131839
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3131632
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[dildick]

Comparison looks good. For one WF (20034.0) the CSC DQM comparison failed in one plot, namely for Plus_endcap_CLCT0_dTime. This was discussed prior in this thread and is not relevant to MC. @tahuang1991

[dildick]

@fabiocos Do you have any comments on this PR?

[fabiocos]

@dildick in the description you mention improvement of the data/emulator agreement, but in the limited statistics of tests of the PR nothing is seen in DQM. Is this due to the small number of events, or what else?

[dildick]

@fabiocos The improvements that we made in the trigger emulator are of the order 0.5% to 1.5%. You probably won't see them in the DQM. @tahuang1991

[fabiocos]

+1