SimDataFormats/ValidationFormats - move G4 dependency out of data format #31273

davidlange6 · 2020-08-28T06:33:06Z

Moved into TrackingMaterialProducer which already depends on G4.

… it (which already had a G4 dependency

cmsbuild · 2020-08-28T06:33:30Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-28T06:40:23Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31273/17961

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31273/17961/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31273/17961/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-08-28T06:58:26Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-28T07:04:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31273/17962

This PR adds an extra 20KB to repository

cmsbuild · 2020-08-28T07:04:56Z

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

BigProducts/Simulation
SimDataFormats/ValidationFormats
SimTracker/TrackerMaterialAnalysis

@smuzaffar, @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @apsallid, @lecriste, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

vargasa

Hello @davidlange6. Is it possible for you to update the same producer in the dd4hep folder please?

vargasa · 2020-08-28T07:30:32Z

SimTracker/TrackerMaterialAnalysis/plugins/TrackingMaterialProducer.cc

+  if (enter_sensitive) {
+    if (m_track_volume != nullptr) {
+      edm::LogWarning("TrackingMaterialProducer") << "Entering volume " << sensitive << "while inside volume "
+                                                  << m_track_volume << ". Something is inconsistent";


Hello @davidlange6. If this is inconsistent, is a warning enough?

No idea. it was a cerr which I wanted to make a message logger

@davidlange6 by running:

cmsRun SimTracker/TrackerMaterialAnalysis/test/trackingMaterialProducer10GeVNeutrino_ForPhaseI.py

Now I get thousands of printouts like this:

Entering volume TECModule2RphiActivewhile inside volume TECModule1StereoActive. Something is inconsistent Entering volume TECModule1RphiActivewhile inside volume TECModule2RphiActive. Something is inconsistent Entering volume TECModule1StereoActivewhile inside volume TECModule1RphiActive. Something is inconsistent Entering volume TECModule2RphiActivewhile inside volume TECModule1StereoActive. Something is inconsistent Entering volume TECModule2RphiActivewhile inside volume TECModule2RphiActive. Something is inconsistent Entering volume TECModule3RphiActivewhile inside volume TECModule2RphiActive. Something is inconsistent Entering volume TECModule3RphiActivewhile inside volume TECModule3RphiActive. Something is inconsistent Entering volume TECModule4StereoActivewhile inside volume TECModule3RphiActive. Something is inconsistent Entering volume TECModule4RphiActivewhile inside volume TECModule4StereoActive. Something is inconsistent Entering volume TECModule3RphiActivewhile inside volume TECModule4RphiActive. Something is inconsistent Entering volume TECModule4StereoActivewhile inside volume TECModule3RphiActive. Something is inconsistent Entering volume TECModule4RphiActivewhile inside volume TECModule4StereoActive. Something is inconsistent Entering volume PixelBarrelActiveFull1while inside volume PixelBarrelActiveFull0. Something is inconsistent Entering volume PixelBarrelActiveFull2while inside volume PixelBarrelActiveFull1. Something is inconsistent Entering volume PixelBarrelActiveFull3while inside volume PixelBarrelActiveFull2. Something is inconsistent Entering volume TIBActiveRphi0while inside volume PixelBarrelActiveFull3. Something is inconsistent Entering volume TIBActiveSter0while inside volume TIBActiveRphi0. Something is inconsistent Entering volume TIBActiveRphi0while inside volume TIBActiveSter0. Something is inconsistent Entering volume TIBActiveSter0while inside volume TIBActiveRphi0. Something is inconsistent Entering volume TIBActiveRphi2while inside volume TIBActiveSter0. Something is inconsistent Entering volume TIBActiveRphi2while inside volume TIBActiveRphi2. Something is inconsistent Entering volume TOBActiveRphi0while inside volume TIBActiveRphi2. Something is inconsistent Entering volume TOBActiveRphi0while inside volume TOBActiveRphi0. Something is inconsistent Entering volume TOBActiveSter0while inside volume TOBActiveRphi0. Something is inconsistent Entering volume TOBActiveRphi0while inside volume TOBActiveSter0. Something is inconsistent Entering volume TOBActiveRphi2while inside volume TOBActiveRphi0. Something is inconsistent Entering volume TOBActiveRphi2while inside volume TOBActiveRphi2. Something is inconsistent Entering volume PixelForwardSensorwhile inside volume PixelBarrelActiveFull0. Something is inconsistent Entering volume PixelForwardSensorwhile inside volume PixelForwardSensor. Something is inconsistent Entering volume PixelForwardSensorwhile inside volume PixelForwardSensor. Something is inconsistent Entering volume PixelForwardSensorwhile inside volume PixelForwardSensor. Something is inconsistent Entering volume PixelBarrelActiveFull1while inside volume PixelBarrelActiveFull0. Something is inconsistent Entering volume PixelBarrelActiveFull2while inside volume PixelBarrelActiveFull1. Something is inconsistent

Can you please double check that these changes do not change the expected behavior? as I pointed out before merging histograms from the unit test are also empty. Thanks

Fixed in #31752

vargasa · 2020-08-28T07:31:30Z

SimTracker/TrackerMaterialAnalysis/plugins/TrackingMaterialProducer.cc

+  if (leave_sensitive) {
+    if (m_track_volume != sensitive) {
+      edm::LogWarning("TrackingMaterialProducer") << "Leaving volume " << sensitive << "while inside volume "
+                                                  << m_track_volume << ". Something is inconsistent";


Should it be an error/exception?

It wasn't before. No change in behavior is proposed...

I see, but this was handled internally by SimDataFormats/ValidationFormats/src/MaterialAccountingTrack.cc. I get a couple of empty histograms. FYI: @mmusich, @mtosi, @apsallid

davidlange6 · 2020-08-28T07:53:05Z

Hello @davidlange6. Is it possible for you to update the same producer in the dd4hep folder please?

can you be more specific? I don't see any needed change.

vargasa · 2020-08-28T08:05:51Z

can you be more specific? I don't see any needed change.

Thank you @davidlange6 Please disregard my previous comment, this particular file didn't use any of the DD/Core classes and is not present in that folder

davidlange6 · 2020-08-28T12:07:38Z

please test

cmsbuild · 2020-08-28T12:07:57Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8982/console Started: 2020/08/28 14:18

cmsbuild · 2020-08-28T13:35:52Z

+1
Tested at: ebe9b72
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-961ef0/8982/summary.html
CMSSW: CMSSW_11_2_X_2020-08-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-28T13:35:54Z

Comparison job queued.

cmsbuild · 2020-08-28T15:04:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-961ef0/8982/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609644
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

davidlange6 · 2020-08-28T15:31:16Z

It’s a condition that doesn’t happen. I’ve handled the error as it was done before unless ice misunderstood the code Cheers, David On 28 Aug 2020, at 17:20, Andres Vargas <notifications@github.com> wrote: @vargasa commented on this pull request.

________________________________ In SimTracker/TrackerMaterialAnalysis/plugins/TrackingMaterialProducer.cc<#31273 (comment)>:

m_track.step(MaterialAccountingStep(length, radiationLengths, energyLoss, globalPositionIn, globalPositionOut));

- if (leave_sensitive) - m_track.leaveDetector(sensitive, cosThetaPost); - + if (leave_sensitive) { + if (m_track_volume != sensitive) { + edm::LogWarning("TrackingMaterialProducer") << "Leaving volume " << sensitive << "while inside volume " + << m_track_volume << ". Something is inconsistent"; I see, but this was handled internally by SimDataFormats/ValidationFormats/src/MaterialAccountingTrack.cc. I get a couple of empty histograms<https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-961ef0/8982/trackerMaterialAnalysisPlots/>. FYI: @mmusich<https://github.com/mmusich>, @mtosi<https://github.com/mtosi>, @apsallid<https://github.com/apsallid> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#31273 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQYVDBHGPPSRPGFPEYDSC7DI7ANCNFSM4QNZCPNA>.

civanch · 2020-08-28T23:24:01Z

+1

davidlange6 · 2020-09-03T09:43:42Z

@makortel - any feedback on this PR?

smuzaffar · 2020-09-03T10:06:27Z

+core
for BigProducts/Simulation

cmsbuild · 2020-09-03T10:06:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-09-03T12:07:59Z

+1

moving G4 dependency out of data format and into plugin that consumes…

6b6b103

… it (which already had a G4 dependency

cmsbuild added this to the CMSSW_11_2_X milestone Aug 28, 2020

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures simulation-pending tests-pending labels Aug 28, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 28, 2020

code checks

ebe9b72

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 28, 2020

vargasa reviewed Aug 28, 2020

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Aug 28, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 28, 2020

cmsbuild added simulation-approved and removed simulation-pending labels Aug 28, 2020

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Sep 3, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 3, 2020

cmsbuild merged commit 45b7cfe into cms-sw:master Sep 3, 2020

This was referenced Sep 3, 2020

to make static analyzer happy in RunningAverage #31352

Merged

Modernized AlcaBeamMonitor #31354

Merged

davidlange6 mentioned this pull request Oct 12, 2020

TrackingMaterialProducer fix in volume accounting #31752

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SimDataFormats/ValidationFormats - move G4 dependency out of data format #31273

SimDataFormats/ValidationFormats - move G4 dependency out of data format #31273

davidlange6 commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

vargasa left a comment

vargasa Aug 28, 2020

davidlange6 Aug 28, 2020

vargasa Oct 9, 2020

davidlange6 Oct 12, 2020

vargasa Aug 28, 2020

davidlange6 Aug 28, 2020

vargasa Aug 28, 2020

davidlange6 commented Aug 28, 2020

vargasa commented Aug 28, 2020

davidlange6 commented Aug 28, 2020

cmsbuild commented Aug 28, 2020 •

edited

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

davidlange6 commented Aug 28, 2020 via email

civanch commented Aug 28, 2020

davidlange6 commented Sep 3, 2020

smuzaffar commented Sep 3, 2020 •

edited

cmsbuild commented Sep 3, 2020

qliphy commented Sep 3, 2020

SimDataFormats/ValidationFormats - move G4 dependency out of data format #31273

SimDataFormats/ValidationFormats - move G4 dependency out of data format #31273

Conversation

davidlange6 commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

vargasa left a comment

Choose a reason for hiding this comment

vargasa Aug 28, 2020

Choose a reason for hiding this comment

davidlange6 Aug 28, 2020

Choose a reason for hiding this comment

vargasa Oct 9, 2020

Choose a reason for hiding this comment

davidlange6 Oct 12, 2020

Choose a reason for hiding this comment

vargasa Aug 28, 2020

Choose a reason for hiding this comment

davidlange6 Aug 28, 2020

Choose a reason for hiding this comment

vargasa Aug 28, 2020

Choose a reason for hiding this comment

davidlange6 commented Aug 28, 2020

vargasa commented Aug 28, 2020

davidlange6 commented Aug 28, 2020

cmsbuild commented Aug 28, 2020 • edited

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

cmsbuild commented Aug 28, 2020

davidlange6 commented Aug 28, 2020 via email

civanch commented Aug 28, 2020

davidlange6 commented Sep 3, 2020

smuzaffar commented Sep 3, 2020 • edited

cmsbuild commented Sep 3, 2020

qliphy commented Sep 3, 2020

cmsbuild commented Aug 28, 2020 •

edited

smuzaffar commented Sep 3, 2020 •

edited