Fix scram b code-checks warnings associated with FWCore

[Dr15Jones]

PR description:

Mostly this was moving =delete methods to public section and removing unnecessary uses of std::move.

PR validation:

code compiles. Running scram b code-checks no longer gives any warning for FWCore/Framework or FWCore/Utilities.

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

NOTE: this changed allowed a use of std::move to actually do something useful.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31396/18243

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/Path.h modified in PR(s): Use TransitionInfo in more interfaces, part 2 #31136, Use TransitionInfo in more interfaces #30969
  • File FWCore/Framework/src/SystemTimeKeeper.h modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/Provenance
FWCore/Framework
FWCore/Utilities

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @rovere, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-08-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9199/console Started: 2020/09/08 21:16

[cmsbuild]

+1
Tested at: 24df5ff
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-232898/9199/summary.html
CMSSW: CMSSW_11_2_X_2020-09-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-232898/9199/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2609639
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1