Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back tracking particle selector, modify cuts to new defaults #3142

Conversation

mdhildreth
Copy link
Contributor

Added selector to TrackingParticles by default, change cut values to those recommended by tracking DPG.

@mdhildreth
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@andersonjacob
Copy link
Contributor

Essentially everything fails after this PR with the log file:

globaltag = DES19_62_V8::All
271 DQMStore::DQMStore 
HcalTopologyIdealEP::HcalTopologyIdealEP
02-Apr-2014 15:05:01 CEST  Initiating request to open file file:step1.root
02-Apr-2014 15:05:02 CEST  Successfully opened file file:step1.root
02-Apr-2014 15:05:02 CEST  Closed file file:step1.root
----- Begin Fatal Exception 02-Apr-2014 15:05:02 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'stableOnlyTP' not found.
----- End Fatal Exception -------------------------------------------------

Is there a parameter missing in the configuration?

@mark-grimes
Copy link

This should be closed, it's included in #3191. I thought it would close automatically because all of the commits were merged when #3191 was merged, but that doesn't seem to have happened. @davidlange6 could you close this please?

@ktf ktf closed this Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants