Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anti-electron tauID for phase2 #31470

Merged
merged 26 commits into from Oct 20, 2020

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Sep 15, 2020

PR description:

This PR add a new anti-electron tauID for phase2.

The newly added tauID is a variant of already existing anti-e MVA6 tauID with updated set of variables and new training dedicated to phase2 detector and conditions. Expected preformance was presented here: https://indico.cern.ch/event/831606/contributions/3483936/attachments/1872137/3081088/TauID_1Jul19.pdf

The tauID is run in the miniAOD sequence and embedded into slimmedTaus collection when triggered by a phase2 modifier.

FYI @swozniewski

PR validation:

  • Tested with a dedicated phase2 miniAOD workflow with the following cmsDriver command (with CMSSW_11_2_0_pre6):
cmsDriver.py miniAOD2026 --filein /store/relval/CMSSW_11_2_0_pre3/RelValTTbar_14TeV/GEN-SIM-RECO/PU25ns_110X_mcRun4_realistic_v3_2026D49PU200_rsb-v1/20000/0C3CD0A0-D194-E24A-932C-153BF677AD19.root --fileout file:MiniAOD2026.root --mc --eventcontent MINIAODSIM --datatier MINIAODSIM --conditions auto:phase2_realistic_T15 --step PAT --nThreads 6 --geometry Extended2026D49 --scenario pp --era Phase2C9 --procModifiers miniAOD_skip_trackExtras -n -1 --no_exec
  • Matrix tests (runTheMatrix.py -l limited -i all --ibeos) passed successfully.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31470/18385

  • This PR adds an extra 116KB to repository

  • Found files with invalid states:

    • RecoTauTag/RecoTau/python/PATTauDiscriminationAgainstElectronMVA6_cff.py:
    • RecoTauTag/RecoTau/python/PFRecoTauDiscriminationAgainstElectronMVA6_cff.py:
  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for master.

It involves the following packages:

CommonTools/Egamma
PhysicsTools/PatAlgos
RecoTauTag/Configuration
RecoTauTag/RecoTau

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@jdamgov, @rappoccio, @gouskos, @jdolen, @ahinzmann, @smoortga, @riga, @schoef, @emilbols, @mariadalfonso, @JyothsnaKomaragiri, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @peruzzim, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Sep 15, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 15, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 9277c0b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b7c56/10038/summary.html
CMSSW: CMSSW_11_2_X_2020-10-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b7c56/10038/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 27 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543752
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543729
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@santocch
Copy link

+1

@kpedro88
Copy link
Contributor

+upgrade
as expected, changes only occur in patTaus_slimmedTaus__RECO_obj___tauIDs in Phase 2 workflows

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 20, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants