Use std::string_view for MessageLogger category

[makortel]

PR description:

Resolves #31475. Should avoid one std::string construction when the category is passed in as char const*.

PR validation:

Framework unit tests pass.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31498/18447

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/MessageLogger/interface/ErrorObj.h modified in PR(s): Add support of printf()-like formatting to MessageLogger #30629
  • File FWCore/MessageLogger/interface/MessageLogger.h modified in PR(s): Add support of printf()-like formatting to MessageLogger #30629
  • File FWCore/MessageLogger/interface/MessageSender.h modified in PR(s): Add support of printf()-like formatting to MessageLogger #30629

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/MessageLogger

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9410/console Started: 2020/09/17 20:16
• CMSSW_11_2_X_2020-09-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9417/console Started: 2020/09/17 23:43

[makortel]

@Dr15Jones Given that ELseverityLevel is essentially an int, I wonder if we should pass it around by value instead of by reference?

[Dr15Jones]

Passing by value makes sense to me. (Much of the internals of MessageLogger are C++98 era of code)

[Dr15Jones]

Could you also go the extra mile and get rid of all references to ELstring? It is completely unnecessary as we already directly depend upon std::string in our interfaces.

[makortel]

Could you also go the extra mile and get rid of all references to ELstring?

Happy to.

[kpedro88]

thanks @makortel!

[cmsbuild]

+1
Tested at: f77d8b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-875a32/9417/summary.html
CMSSW: CMSSW_11_2_X_2020-09-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-875a32/9417/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2540471
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2540448
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1