[DD4hep] Introduce DD4hep Era for Tracker #31517

ianna · 2020-09-20T21:55:05Z

merge DD and DD4hep TrackerParameters producer to allow its use in a dd4hep Era
introduce an Era for trackerParameters configuration. That allows us reusing the same RECO geometry configuration rather then its DD4hep duplication
update geometry dictionaries for all 2021 and 2026 scenarios to allow selecting a dd4hep Era for Tracker
regenerate all 2021 and 2026 scenarios
simplify test configuration based on an dd4hep Era
fix and cleanup test configurations to be able to run them
cleanup tests
move test configurations to a test/python directory
introduce a script to automatically run all the tests in Geometry/TrackerGeometryBuilder

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-09-20T21:55:32Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-20T22:01:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31517/18483

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Geometry/python/GeometryDD4hepExtended2021Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2021Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2021ZeroMaterialReco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D49Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D50Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D51Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D53Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D54Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D56Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D57Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D58Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D59Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D60Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D61Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D62Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D63Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D64Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/GeometryExtended2026D65Reco_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/dict2021Geometry.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): update the tracking material for Phase2 geometry D49 #30126, [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Geometry/TrackerGeometryBuilder/plugins/BuildFile.xml modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Geometry/TrackerGeometryBuilder/plugins/TrackerParametersESModule.cc modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Geometry/TrackerGeometryBuilder/plugins/dd4hep/TrackerParametersESProducer.cc modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482
- File Geometry/TrackerGeometryBuilder/python/trackerParameters_cff.py modified in PR(s): [DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482

cmsbuild · 2020-09-20T22:01:27Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Configuration/Geometry
Geometry/TrackerGeometryBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @JanFSchulte, @VinInn, @Martin-Grunewald, @ebrondol, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

ianna · 2020-09-21T06:11:04Z

please test

cmsbuild · 2020-09-21T06:11:26Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-20-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9446/console Started: 2020/09/21 08:12

cmsbuild · 2020-09-21T07:26:39Z

+1
Tested at: 0a67254
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abf3c0/9446/summary.html
CMSSW: CMSSW_11_2_X_2020-09-20-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-21T07:26:41Z

Comparison job queued.

cmsbuild · 2020-09-21T08:53:30Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abf3c0/9446/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2540471
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2540442
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

ianna · 2020-09-21T13:32:19Z

+1

ianna · 2020-09-21T13:34:45Z

@kpedro88 - please, review

davidlange6 · 2020-09-21T13:44:28Z

Configuration/Geometry/python/GeometryDD4hepExtended2021Reco_cff.py

@@ -11,6 +11,7 @@

 #Tracker
 from RecoTracker.GeometryESProducer.TrackerRecoGeometryESProducer_cfi import *
+from Geometry.TrackerGeometryBuilder.trackerParameters_cff import *


not an issue created by this PR - however having parallel cffs (with / without DD4hep) and a dd4hep era is a rather error prone situation.. What ensures that these do not get mixed up?

agree. The dd4hep-specific configurations should go away as soon as all the sub detectors have era-enabled fragments.

kpedro88 · 2020-09-21T14:30:01Z

+upgrade

cmsbuild · 2020-09-21T14:30:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

ianna · 2020-09-21T15:37:14Z

@silviodonato, @dpiparo, @qliphy - please, consider integration asap. @ghugo83's and @bsunanda's imminent PRs depend on this.

silviodonato · 2020-09-21T15:59:17Z

+1

introduce dd4hep era for Tracker

0a67254

cmsbuild added this to the CMSSW_11_2_X milestone Sep 20, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Sep 20, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 20, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 21, 2020

ianna mentioned this pull request Sep 21, 2020

[DD4hep] DDFilteredView API Enhancement and Tracker Configuration by Era #31482

Closed

cmsbuild added tests-approved and removed tests-started labels Sep 21, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 21, 2020

cmsbuild added geometry-approved and removed geometry-pending labels Sep 21, 2020

davidlange6 reviewed Sep 21, 2020

View reviewed changes

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Sep 21, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 21, 2020

cmsbuild merged commit 18f41ed into cms-sw:master Sep 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DD4hep] Introduce DD4hep Era for Tracker #31517

[DD4hep] Introduce DD4hep Era for Tracker #31517

ianna commented Sep 20, 2020

cmsbuild commented Sep 20, 2020

cmsbuild commented Sep 20, 2020

cmsbuild commented Sep 20, 2020

ianna commented Sep 21, 2020

cmsbuild commented Sep 21, 2020 •

edited

cmsbuild commented Sep 21, 2020

cmsbuild commented Sep 21, 2020

cmsbuild commented Sep 21, 2020

ianna commented Sep 21, 2020

ianna commented Sep 21, 2020

davidlange6 Sep 21, 2020

ianna Sep 21, 2020

kpedro88 commented Sep 21, 2020

cmsbuild commented Sep 21, 2020

ianna commented Sep 21, 2020

silviodonato commented Sep 21, 2020

[DD4hep] Introduce DD4hep Era for Tracker #31517

[DD4hep] Introduce DD4hep Era for Tracker #31517

Conversation

ianna commented Sep 20, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 20, 2020

cmsbuild commented Sep 20, 2020

cmsbuild commented Sep 20, 2020

ianna commented Sep 21, 2020

cmsbuild commented Sep 21, 2020 • edited

cmsbuild commented Sep 21, 2020

cmsbuild commented Sep 21, 2020

cmsbuild commented Sep 21, 2020

ianna commented Sep 21, 2020

ianna commented Sep 21, 2020

davidlange6 Sep 21, 2020

Choose a reason for hiding this comment

ianna Sep 21, 2020

Choose a reason for hiding this comment

kpedro88 commented Sep 21, 2020

cmsbuild commented Sep 21, 2020

ianna commented Sep 21, 2020

silviodonato commented Sep 21, 2020

cmsbuild commented Sep 21, 2020 •

edited