-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the tracking material for Phase2 geometry D49 #30126
Conversation
The code-checks are being triggered in jenkins. |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30126/15903
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @mtosi (mia tosi) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -38,7 +38,7 @@ | |||
'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker613/pixelStructureTopology.xml', | |||
'Geometry/TrackerSimData/data/PhaseII/TiltedTracker404/trackersens.xml', | |||
'Geometry/TrackerSimData/data/PhaseII/TiltedTracker404/pixelsens.xml', | |||
'Geometry/TrackerRecoData/data/PhaseII/TiltedTracker613_MB_2019_04/trackerRecoMaterial.xml', | |||
'Geometry/TrackerRecoData/data/PhaseII/OuterTracker616_2020_04/trackerRecoMaterial.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kpedro88 this is the reconstruction material file and has nothing to do with the simulation material used for the simulation step. |
@cmsbuild please abort |
Jenkins tests are aborted. |
@mmusich thanks for clarifying. In this case, it should be acceptable (if the HLT TDR conveners agree). |
@kpedro88 actually Mia agreed to send an e-mail to you + HLT TDR conveners and offline coordination, with all the considerations leading to this change. |
@mtosi , please, close this. |
@mtosi |
@mtosi you declared would have closed this one since Dec 2020. |
PR description:
the validation of the new tracking material description originally introduced in #29910
has been shown today at the Tracker Phase2 Upgrade Simulation Meeting slide
it turns out that this material provides better tracking performance
in summary
so, from the TK DPG (@mmusich @emiglior @skinnari) and TRK POG this new material even if it is still not the optimal one for this geometry, it seems to be better than what we currently use in the standard reconstruction
we would propose to make use of this material (for both the offline and online track reconstruction) for the HLT TDR
[1]
in particular
generalTracks:
https://jalimena.web.cern.ch/jalimena/plots/track_validation_plots_TTbar_D49PU200_11_1_0_pre8_vs_recoMaterial/plots_ootb/effandfakePtEtaPhi.pdf
HP:
https://jalimena.web.cern.ch/jalimena/plots/track_validation_plots_TTbar_D49PU200_11_1_0_pre8_vs_recoMaterial/plots_highPurity/effandfakePtEtaPhi.pdf
HP w/ pT > 0.9 GeV:
https://jalimena.web.cern.ch/jalimena/plots/track_validation_plots_TTbar_D49PU200_11_1_0_pre8_vs_recoMaterial/plots_highPurityPt09/effandfakePtEtaPhi.pdf
FromPVForAllTP w/ pT > 0.9 GeV:
https://jalimena.web.cern.ch/jalimena/plots/track_validation_plots_TTbar_D49PU200_11_1_0_pre8_vs_recoMaterial/plots_fromPVAllTP_highPurityPt09/effandfakePtEtaPhi.pdf
[2]
https://jalimena.web.cern.ch/jalimena/plots/track_validation_plots_TTbar_D49PU200_11_1_0_pre8_vs_recoMaterial/plots_highPurity/pulls.pdf
PR validation:
runTheMatrix.py -l limited -i all --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
we would backport this PR in 111x