Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the tracking material for Phase2 geometry D49 #30126

Closed
wants to merge 3 commits into from

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jun 5, 2020

PR description:

the validation of the new tracking material description originally introduced in #29910
has been shown today at the Tracker Phase2 Upgrade Simulation Meeting slide

it turns out that this material provides better tracking performance
in summary

  • efficiency almost unchanged
  • increase of fake rate (but mainly from low-pT tracks and the PU tracks) [1]
  • IP resolutions almost unchanged
  • improvement in the pT resolution
  • improvement in the pulls [2]
  • improvement in the pT scale [2]

so, from the TK DPG (@mmusich @emiglior @skinnari) and TRK POG this new material even if it is still not the optimal one for this geometry, it seems to be better than what we currently use in the standard reconstruction

we would propose to make use of this material (for both the offline and online track reconstruction) for the HLT TDR

[1]
in particular

[2]
https://jalimena.web.cern.ch/jalimena/plots/track_validation_plots_TTbar_D49PU200_11_1_0_pre8_vs_recoMaterial/plots_highPurity/pulls.pdf

PR validation:

runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

we would backport this PR in 111x

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2020

The code-checks are being triggered in jenkins.

@mtosi
Copy link
Contributor Author

mtosi commented Jun 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30126/15903

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2020

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@@ -38,7 +38,7 @@
'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker613/pixelStructureTopology.xml',
'Geometry/TrackerSimData/data/PhaseII/TiltedTracker404/trackersens.xml',
'Geometry/TrackerSimData/data/PhaseII/TiltedTracker404/pixelsens.xml',
'Geometry/TrackerRecoData/data/PhaseII/TiltedTracker613_MB_2019_04/trackerRecoMaterial.xml',
'Geometry/TrackerRecoData/data/PhaseII/OuterTracker616_2020_04/trackerRecoMaterial.xml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtosi I don't understand this change...
Should not this file be instead moved to point to Geometry/TrackerRecoData/data/PhaseII/TiltedTracker613_MB_2019_04/v2_ITonly/trackerRecoMaterial.xml
as it was done for the customization PR: #29910 ?

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 5, 2020

@mtosi typically we do not allow changes in Phase 2 geometries that have already been used in production. In particular, this may interfere with the planned re-reco for the HLT TDR, which will use existing DIGI samples generated with the existing geometry. @fwyzard @trtomei please comment

@mmusich
Copy link
Contributor

mmusich commented Jun 5, 2020

@mtosi typically we do not allow changes in Phase 2 geometries that have already been used in production. In particular, this may interfere with the planned re-reco for the HLT TDR, which will use existing DIGI samples generated with the existing geometry. @fwyzard @trtomei please comment

@kpedro88 this is the reconstruction material file and has nothing to do with the simulation material used for the simulation step.

@mtosi
Copy link
Contributor Author

mtosi commented Jun 5, 2020

@cmsbuild please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2020

Jenkins tests are aborted.

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 5, 2020

@mmusich thanks for clarifying. In this case, it should be acceptable (if the HLT TDR conveners agree).

@mmusich
Copy link
Contributor

mmusich commented Jun 5, 2020

@kpedro88 actually Mia agreed to send an e-mail to you + HLT TDR conveners and offline coordination, with all the considerations leading to this change.

@civanch
Copy link
Contributor

civanch commented Jan 24, 2021

@mtosi , please, close this.

@srimanob
Copy link
Contributor

@mtosi
Would you mind to close this PR? Thanks.

@perrotta
Copy link
Contributor

@mtosi you declared would have closed this one since Dec 2020.
I'm closing it now, please re-open it if you changed you mind (and please comment here about the plans for this PR in that case)

@perrotta perrotta closed this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet