L1T Phase2 NN Tau (11_3_X)

[rekovic]

PR description:

11_2_X: L1T Phase2 NNTau reconstruction based on PF and Puppi

• producers (PF and Puppi) and configurations
• included in L1T Phase2 sequence
• included in FEVTDEBUG Phase2 EventContent

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[rekovic]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31601/18652

• This PR adds an extra 24KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-27-0000/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9603/console Started: 2020/09/28 00:50

[cmsbuild]

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/Phase2L1ParticleFlow

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 355bfd3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6aa50/9603/summary.html
CMSSW: CMSSW_11_2_X_2020-09-27-0000
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6aa50/9603/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2539438
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2539406
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[rekovic]

+1

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31601/20170

• This PR adds an extra 68KB to repository

• Found files with invalid states:

  • L1Trigger/Phase2L1ParticleFlow/interface/L1NNTauProducer.h:
    • Added: 7604e15
    • Modified: a56c92f, 5603966
    • Deleted: 0da99ef
  • L1Trigger/Phase2L1ParticleFlow/interface/L1NNTauProducer.hh:
    • Added: 9c058ee
    • Modified: b2997fe, 2fa3d4d, e649ca2, 95626c0
    • Deleted: 7604e15

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_3_X_2020-11-30-1100/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11180/console Started: 2020/11/30 20:11

[cmsbuild]

Pull request #31601 was updated. @cmsbuild, @rekovic, @kpedro88, @jmduarte can you please check and sign again.

[cmsbuild]

+1
Tested at: 46e2b71
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6aa50/11180/summary.html
CMSSW: CMSSW_11_3_X_2020-11-30-1100
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6aa50/11180/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 13 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2529551
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 148 log files, 34 edm output root files, 35 DQM output files

[rekovic]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1