Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PPS tags in Run 2 offline GTs for re-miniAOD #31635

Merged
merged 1 commit into from Oct 6, 2020

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR updates two PPS records, CTPPSOpticsRcd and RPRealAlignmentRecord as described in a presentation in the May 18, 2020 AlCaDB meeting.

It also removes an obsolete record L1TMuonEndcapParamsRcd from the GT (the record with a capital 'C' in EndCap remains), which is purely technical. Once this record is removed from all GTs in production, it can be removed from CMSSW.

The GT diffs are as follows:

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_v3/112X_dataRun2_v4

Offline data (HEM failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_HEfail_v3/112X_dataRun2_HEfail_v4

Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_relval_v3/112X_dataRun2_relval_v4

PR validation:

Please see the presentation in the May 18, 2020 AlCaDB meeting for details. In addition, a technical test was performed:

runTheMatrix.py -l limited,136.8642,136.72411 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport but will be backported to 106X for use in the Run 2 re-miniAOD.

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 136.8642,136.72411

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31635/18713

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 30, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2020

+1
Tested at: 2037e05
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3da2e/9674/summary.html
CMSSW: CMSSW_11_2_X_2020-09-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3da2e/9674/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a3da2e/136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a3da2e/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 79 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 66
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542137
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@christopheralanwest
Copy link
Contributor Author

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants