Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of phase2 Tracker geometries T17, T19, T20 and migrations #31673

Merged
merged 5 commits into from Oct 7, 2020

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Oct 5, 2020

PR description:

This PR supersedes #31572. In addition to the removals in that PR, the HGCal development geometries D57, D58, D59, D62 are migrated from T17 to T21, producing D68, D69, D70, D71. The muon geometry M5 is removed as no longer relevant (see discussion in #30512). D63 is removed as redundant with D68.

PR validation:

  • checked that runTheMatrix workflow numbers for existing workflows stayed the same
  • ran new workflows 31434.0,31834.0,32234.0,32634.0 successfully

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31673/18800

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Configuration/AlCa
Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData

@civanch, @Dr15Jones, @silviodonato, @jordan-martins, @chayanit, @cvuosalo, @wajidalikhan, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @makortel, @franzoni, @yuanchao, @tocheng, @tlampen, @qliphy, @pohsun, @fabiocos, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @tocheng, @lecriste, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Oct 5, 2020

test parameters
workflows = 31434.0,31834.0,32234.0,32634.0

@kpedro88
Copy link
Contributor Author

kpedro88 commented Oct 5, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

+1
Tested at: faa1b4d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-795b58/9740/summary.html
CMSSW: CMSSW_11_2_X_2020-10-05-1200
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

Comparison job queued.

@cvuosalo
Copy link
Contributor

cvuosalo commented Oct 5, 2020

+1

@chayanit
Copy link

chayanit commented Oct 6, 2020

+1

@emiglior
Copy link
Contributor

emiglior commented Oct 6, 2020

@duartej this is of interest for you

@christopheralanwest
Copy link
Contributor

@mmusich Do you have any comments on this PR?

@mmusich
Copy link
Contributor

mmusich commented Oct 6, 2020

@mmusich Do you have any comments on this PR?

This PR finally closes issue #30512, hence has full approval of Tk DPG. Thanks.

@christopheralanwest
Copy link
Contributor

+alca

@silviodonato
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants