Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TkAl] Update PV Validation and PV Resolution per-run submission tools #31694

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 7, 2020

PR description:

The aim of this PR is to update the Tracker Alignment PV Validation and PV Resolution per run submission tools.
The list of features introduced in this PR are:

  • added the executable script: submitPVValidationJobs.py;
  • added possibility of configuring refitter sequence and CPE type from submission;
  • updated the example ini files with the lauching script, now in the path;
  • updated unit test to run job submitters;
  • included all modification to be compliant with both Py2 and Py3;

PR validation:

Relies on the existing (and augmented) unit tests, both in the regular build CMSSW_11_2_X_2020-10-01-2300 and in the Py3 build CMSSW_11_2_PY3_X_2020-10-04-2300.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport, and no backport is immediately needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31694/18847

  • This PR adds an extra 48KB to repository

  • Found files with invalid states:

    • Alignment/OfflineValidation/test/PVValidation_T_standardRefit_cfg.py:
    • Alignment/OfflineValidation/test/PVValidationHTCondorSubmitter.py:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/OfflineValidation

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 7, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

-1

Tested at: 500a29e

CMSSW: CMSSW_11_2_X_2020-10-06-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c432/9772/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2020

Comparison job queued.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 8, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c432/9802/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542196
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

+1
Tested at: d5bd310
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c432/9803/summary.html
CMSSW: CMSSW_11_2_X_2020-10-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c432/9803/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542196
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@yuanchao
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants