Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from MagneticField_AutoFromDBCurrent_cff to MagneticField in all Tracker-related configurations #31788

Merged
merged 1 commit into from Oct 21, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 14, 2020

PR description:

It has been hinted in #31651 (comment) that the MagneticField_AutoFromDBCurrent_cff configuration fragment might get to be obsoleted soon.
Looking into it, it just imports Configuration.StandardSequences.MagneticField_cff:

# This cff is obsolete and will eventually be deprecated.
# Please replace it with
# Configuration.StandardSequences.MagneticField_cff.py
# in your setup.
from Configuration.StandardSequences.MagneticField_cff import *

I've moved all the pieces of configuration that are broadly speaking under the responsibility of Tracker DPG to Configuration.StandardSequences.MagneticField_cff and removed them where duplicated.
This should solve quite a few of the failing unit tests spotted in #31651 (comment)

PR validation:

Compiles. No regressions are expected as the generated configurations should be verbatim the same.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport is needed.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31788/19053

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm
Alignment/OfflineValidation
CalibTracker/SiPixelLorentzAngle
CalibTracker/SiPixelQuality
CalibTracker/SiStripChannelGain
CalibTracker/SiStripCommon
CondTools/SiPixel
DPGAnalysis/SiStripTools
DQM/SiPixelMonitorClient
DQM/SiPixelMonitorDigi
DQM/SiPixelPhase1Config
DQM/SiStripCommissioningAnalysis
DQM/SiStripMonitorClient
DQM/SiStripMonitorCluster
DQM/SiTrackerPhase2
DQM/TrackingMonitorSource
EventFilter/SiPixelRawToDigi
RecoLocalTracker/SiStripClusterizer
Validation/SiTrackerPhase2V

@perrotta, @andrius-k, @yuanchao, @kmaeshima, @tlampen, @christopheralanwest, @ErnestaP, @tocheng, @cmsbuild, @jpata, @jfernan2, @fioriNTU, @slava77, @ggovi, @pohsun, @santocch can you please review it and eventually sign? Thanks.
@erikbutz, @echabert, @felicepantaleo, @yduhm, @robervalwalsh, @Martin-Grunewald, @mschrode, @fioriNTU, @tlampen, @threus, @ebrondol, @venturia, @hdelanno, @makortel, @JanFSchulte, @ferencek, @pieterdavid, @sroychow, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @jandrea, @alesaggio, @idebruyn, @mmusich, @mtosi, @arossi83, @adewit, @gbenelli, @dkotlins, @gpetruc, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@perrotta
Copy link
Contributor

please test
(is bot stuck?)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 14be007
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74acbc/9954/summary.html
CMSSW: CMSSW_11_2_X_2020-10-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74acbc/9954/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543752
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543717
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

+1

@santocch
Copy link

+1

@perrotta
Copy link
Contributor

+1

  • Trivial rename for reco
  • Jenkins tests pass

@silviodonato
Copy link
Contributor

kind reminder @cms-sw/alca-l2 @cms-sw/db-l2

@yuanchao
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

urgent
can we merge this PR in pre8?
@cms-sw/db-l2

@silviodonato
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants