Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TrackingEffFromHitPatternClientConfigZeroBias and use it for the trackingZeroBias DQM Harvesting sequence #31713

Merged
merged 1 commit into from Oct 9, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 8, 2020

PR description:

The title says it all.
We've been requested from central DQM to investigate the messages related to:

%MSG-e DQMGenericClient:  DQMGenericClient:trackingEffFromHitPattern@endRun  07-Oct-2020 09:19:57 CEST End Run: 194533
 DQMGenericClient::findAllSubdirectories ==> Missing folder Tracking/TrackParameters/highPurityTracks/pt_1/HIP_OOT_noINpu !!!
%MSG

in the relval workflows (see e.g. this log ).
It turns out this is related to the fact that the triggers populating the MEs in the special folders (i.e. FirstCollisionInTrain FirstCollisionAfterAbortGap, FirstBXAfterTrain) are not present in any other dataset than ZeroBias.
So the TrackingEffFromHitPatternClientConfig (configured in order to look for the special folders) has been cloned and used for the trackingZeroBias DQM Harvesting sequence .

PR validation:

Tested in CMSSW_11_2_X_2020-10-08-1100:

  • runTheMatrix.py -l 4.53 -t 4 -j 8 : warning messages in step4 are gone.
  • runTheMatrix.py -l 136.892 -t 4 -j 8: using the DQMHarvestTrackingZeroBias sequence, runs smoothly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

cc:
@mtosi, @sroychow, @arossi83, @tsusa

…r the trackingZeroBias DQM Harvesting sequence
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31713/18895

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

DQM/TrackingMonitorClient
DQMOffline/Configuration

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @makortel, @sroychow, @JanFSchulte, @fioriNTU, @jandrea, @mtosi, @idebruyn, @threus, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 8, 2020

test parameters:
workflows = 4.53, 136.892

@mmusich
Copy link
Contributor Author

mmusich commented Oct 8, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

+1
Tested at: 65ba868
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-208eb7/9812/summary.html
CMSSW: CMSSW_11_2_X_2020-10-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-208eb7/9812/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-208eb7/136.892_RunZeroBias2018D+RunZeroBias2018D+HLTDR2_2018+RECODR2_2018reHLT_ZBPrompt+HARVEST2018_PromptZB

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542190
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 9, 2020

Thank you very much for this PR @mmusich
Could it be possible/easy to remove also this one:
MSG-e DQMGenericClient: DQMGenericClient:postProcessorTrack@endRun 08-Oct-2020 18:59:48 CEST End Run: 1
DQMGenericClient::findAllSubdirectories ==> Missing folder Tracking/TrackBHadron !!!

@mmusich
Copy link
Contributor Author

mmusich commented Oct 9, 2020

@jfernan2
yes I noticed that message as well. That requires a different fix in different files. I would suggest to proceed with this one for the time being if you agree. I'll follow up to the other one later.

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 9, 2020

+1

@mmusich
Copy link
Contributor Author

mmusich commented Oct 14, 2020

@jfernan2

Could it be possible/easy to remove also this one:
MSG-e DQMGenericClient: DQMGenericClient:postProcessorTrack@endRun 08-Oct-2020 18:59:48 CEST End Run: 1
DQMGenericClient::findAllSubdirectories ==> Missing folder Tracking/TrackBHadron !!!

for the record that's addressed at: #31785

@mmusich mmusich deleted the removeTrackingHarvestingMessages branch October 14, 2020 11:14
@jfernan2
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants