Avoid a dead assignment in DDFilteredView.cc

[perrotta]

PR description:

A dead assignment for an internal bool variable was notified by the static analyzer in DDFilteredView.cc: removed here
At the same time I also took the opportunity to remove a duplicate header include in the same file

PR validation:

Quite trivial update, just checked that it builds correctly
No changes in output expected

[cmsbuild]

The code-checks are being triggered in jenkins.

[perrotta]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31724/18916

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/src/DDFilteredView.cc modified in PR(s): Phase2 IT RechHit DQM and Validation modules #31666, [DD4hep] Introduce FilteredView nextChild #31711, fix DDFilteredView::parameters() crashing with a pseudotrapezoid #31712

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-08-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9824/console Started: 2020/10/09 09:49

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

+1
Tested at: e058e1a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-902eee/9824/summary.html
CMSSW: CMSSW_11_2_X_2020-10-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-902eee/9824/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2542225
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2542194
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-09-1500/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9841/console Started: 2020/10/09 21:26

[cmsbuild]

+1
Tested at: e058e1a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-902eee/9841/summary.html
CMSSW: CMSSW_11_2_X_2020-10-09-1500
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-902eee/9841/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2542225
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2542202
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1