Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup that helps static analyzer #3177

Merged
merged 1 commit into from Apr 4, 2014

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Apr 2, 2014

Remove unused members of DetIdAssociator. Removing
these eliminates some of the spurious problems reported
by the static analyzer used to look for threading
issues.

Remove unused members of DetIdAssociator. Removing
these eliminates some of the spurious problems reported
by the static analyzer used to look for threading
issues.
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_X.

Cleanup that helps static analyzer

It involves the following packages:

TrackingTools/TrackAssociator

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@gpetruc, @cerati, @GiacomoSguazzoni, @rovere, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2014

@slava77
Copy link
Contributor

slava77 commented Apr 4, 2014

+1

for #3177 3531f02
jenkins OK

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Apr 4, 2014
TrackingTools/TrackAssociator -- Cleanup that helps static analyzer
@nclopezo nclopezo merged commit 1e0c2d2 into cms-sw:CMSSW_7_1_X Apr 4, 2014
@wddgit wddgit deleted the cleanupDetIdAssociator branch April 25, 2014 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants