Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for displaced susy relval production (TRK and EXO validation of displaced tracks) #31772

Merged
merged 1 commit into from Oct 16, 2020

Conversation

jalimena
Copy link
Contributor

PR description:

This PR further updates the "DisplacedSUSY" relvals, for tracking and exotica validation of displaced tracks, on top of #31692 , which introduced a problem with WF 1355. In this PR, the original WF 1355 is re-implemented, and only the upgrade WFs related to DisplacedSUSY are changed wrt CMSSW_11_2_0_pre7.

PR validation:

This PR passes the basic unit tests and code quality checks. I have also successfully tested WFs 1355.0 and 23324.0 locally.

if this PR is a backport please specify the original PR and why you need to backport that PR:

not a backport

FYI @mtosi @vmariani @elusiani @Fernance @lowette @nsaoulid @kdipetri @mcitron @jandrea @blochd @mmasciov @chayanit @srappocc

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@jalimena
Copy link
Contributor Author

thanks for your comments, @chayanit, I think this PR addresses them. Let me know if I missed something.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31772/19015

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jalimena (Juliette Alimena) for master.

It involves the following packages:

Configuration/Generator
Configuration/PyReleaseValidation

@SiewYan, @mkirsano, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: adf2d59
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-817233/9916/summary.html
CMSSW: CMSSW_11_2_X_2020-10-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-817233/9916/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543692
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543669
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@chayanit
Copy link

+1

@agrohsje
Copy link

+1

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 16, 2020

+1

@qliphy
Copy link
Contributor

qliphy commented Oct 16, 2020

+1

@qliphy qliphy reopened this Oct 16, 2020
@qliphy qliphy merged commit e8cbd0e into cms-sw:master Oct 16, 2020
@jalimena jalimena deleted the DispSUSYRelValFix branch November 11, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants