Read SLHA from TTree [10_2_X]

[kpedro88]

backport of #31733

This backport was done manually (starting from #32017), because rebasing after code-format changes is painful.

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Read SLHA from TTree #31733

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_2_X_2020-11-03-2300/slc6_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10485/console Started: 2020/11/04 04:00

[cmsbuild]

+1
Tested at: a12aaa0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e16b41/10485/summary.html
CMSSW: CMSSW_10_2_X_2020-11-03-2300
SCRAM_ARCH: slc6_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e16b41/10485/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007546
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007355
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[qliphy]

@kpedro88 Would you please have a check with the Duplicate dictionaries issue with slc6_amd64_gcc700?

[kpedro88]

The reported dictionary issues are unrelated to this PR.

[silviodonato]

@cms-sw/generators-l2 do you have any comments?

[agrohsje]

Hi @silviodonato . I am generally fine with the request. What will happen with the duplicate dictionary above?

[silviodonato]

@agrohsje it is not related to this PR. It is already there in the IB (see https://cmssdt.cern.ch/SDT/cgi-bin/showDupDict.py/slc6_amd64_gcc700/www/mon/10.2-mon-11/CMSSW_10_2_X_2020-11-09-1100/testLogs/dupDict-lostDefs.log).
It might be fixed in another PR.

[agrohsje]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1