Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex34 Make xml files with +-5% and +-10% variation of material budget for 2017 #32054

Merged
merged 1 commit into from Nov 11, 2020

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Nov 7, 2020

PR description:

Make xml files with +-5% and +-10% variation of material budget for 2017

PR validation:

Checked the validity of the xml files using these files in a scenario

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32054/19650

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2020

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/TrackerCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @JanFSchulte, @VinInn, @ebrondol, @ghugo83, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 8, 2020

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

+1
Tested at: 188373c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4c2d7/10575/summary.html
CMSSW: CMSSW_11_2_X_2020-11-08-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4c2d7/10575/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529267
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 9, 2020

The new file Geometry/TrackerCommonData/python/trackGeometry2017XML_cfi.py seems to contain the +-5% variation scenario. But its name is a very generic "Geometry2017". Should this file have a more specific name that indicates it is only for the +-5% scenario?

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 9, 2020

What else will be needed to create DB payloads for these material variation scenarios?

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 9, 2020

@cvuosalo @ianna I needed a python script to test the goodness of all xml files. Once the xml files are approved, I shall define the 4 scenarios in Geometry/CMSCommonData and the cff files in Configuration/Geometry to complete this work. First I check the goodness of the xml files and for that I introduced the cfi file in Geometry/TrackerCommonData. Could you approve this PR?

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit be6c0c1 into cms-sw:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants