Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geant4 tracking in magnetic field parameters #32063

Merged
merged 1 commit into from Nov 11, 2020

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Nov 9, 2020

PR description:

Configuration of Geant4 tracking in magnetic field includes now 3 areas:

  1. relativistic tracks (E > 200 MeV) inside central CMS
  2. low-energy tracks (E < 20 MeV)
  3. remaining tracks
    Such configuration ensure unbiased simulation trajectories for relativistic tracks (bias below 0.1 micron for tracker hits) and do not bring extra CPU penalty and extra Geant4 tracking problems. Detailed discussion on the problem is in Added extra parameters for Geant4 tracking in field #31665.

This PR change simulation histories, so many differences are expected in MC WFs.

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR: no

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32063/19674

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application
SimG4Core/MagneticField

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @namapane, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Nov 9, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

+1
Tested at: 4445f63
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f68ba/10593/summary.html
CMSSW: CMSSW_11_2_X_2020-11-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f68ba/10593/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 41892 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 401286
  • DQMHistoTests: Total nulls: 149
  • DQMHistoTests: Total successes: 2127839
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.477 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.156 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.234 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.158 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -1.362 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 4.075 KiB SiStrip/MechanicalView
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Nov 10, 2020

+1

@silviodonato, @qliphy, let us discuss at the release meeting this PR: when it is the best time to merge it.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

hold
see #32063 (comment)

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@silviodonato
Copy link
Contributor

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
@cms-sw/pdmv-l2 FYI this PR will be the cause of the statistic fluctuation in pre9 validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants