Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define magnetic field parameters for Geant4e as in Geant4 #32268

Merged
merged 1 commit into from Nov 25, 2020

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Nov 24, 2020

PR description:

For Geant4e propagator use the same parameters as established for Geant4 tracking in field at SIM step in (#32063 and #31665)

PR validation:

private

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32268/20051

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

TrackPropagation/Geant4e

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @JanFSchulte, @VinInn, @lecriste, @ebrondol, @mtosi this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Nov 24, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 24, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 022c0f0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f53dbf/11011/summary.html
CMSSW: CMSSW_11_2_X_2020-11-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f53dbf/11011/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2963516
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2963481
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 158 log files, 34 edm output root files, 37 DQM output files

@@ -20,12 +20,12 @@
Type = cms.string('CMSIMField'),
StepperParam = cms.PSet(
MaximumEpsilonStep = cms.untracked.double(0.01), ## in mm
DeltaOneStep = cms.double(0.001), ## in mm
DeltaOneStep = cms.double(1e-4),## in mm
MaximumLoopCounts = cms.untracked.double(1000.0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@civanch,
when trying to fix the Geant4e refitter configuration in 11.2.x for PR #32260
I had to add the following parameters:

    DeltaChordTracker = cms.double(0.001), ## in mm
    DeltaOneStepTracker = cms.double(1e-4),## in mm
    DeltaIntersectionTracker = cms.double(1e-6),## in mm
    RmaxTracker = cms.double(8000),        ## in mm
    ZmaxTracker = cms.double(11000),       ## in mm
    EnergyThTracker = cms.double(0.2),     ## in GeV

shouldn't those be added here as well?

@civanch
Copy link
Contributor Author

civanch commented Nov 25, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
@civanch see #32268 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants