DAQ: fix FedRawData source going out of array boundaries #32116

smorovic · 2020-11-11T21:58:49Z

PR description:

Fix FRD format array version check. Version 6 did not get added to the version size mapping, but was allowed in modules, leading to reading out of boundaries.
This by luck did not cause any problems so far on standard gcc builds on x86_64, but caused assertion in IB tests in for CLANG build, as well as ARM and PPC builds where it was spotted (see #32091)

Fix also removes hardcoded version from around the code. It is now defined only in the same header file where it also defines std::array size.

Bugfix doesn't change any other behavior.
Note: it does NOT affect anything used in production DAQ, only version 5 FRD is used there and that is not affected.

PR validation:

Fixes unit test in EventFilter/Utilities/test for CLANG build.

mapping, but was allowed in modules, leading to reading out of boundaries. Hardcoded version is no longer used now except in header where it also defines array size.

cmsbuild · 2020-11-11T22:04:37Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32116/19767

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32116/19767/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32116/19767/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

makortel · 2020-11-11T22:05:58Z

IOPool/Streamer/interface/FRDEventMessage.h

+const size_t FRDHeaderMaxVersion = 6;
+const std::array<uint32,FRDHeaderMaxVersion+1> FRDHeaderVersionSize = {


How about

Suggested change

const size_t FRDHeaderMaxVersion = 6;

const std::array<uint32,FRDHeaderMaxVersion+1> FRDHeaderVersionSize = {

constexpr size_t FRDHeaderMaxVersion = 6;

constexpr std::array<uint32,FRDHeaderMaxVersion+1> FRDHeaderVersionSize = {

? (although the practical impact may be negiligble)

seems fine, will add it with code checks fix.

cmsbuild · 2020-11-11T22:26:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32116/19768

This PR adds an extra 32KB to repository

cmsbuild · 2020-11-11T22:26:30Z

A new Pull Request was created by @smorovic (Srecko Morovic) for master.

It involves the following packages:

EventFilter/Utilities
IOPool/Streamer

@perrotta, @smuzaffar, @Dr15Jones, @makortel, @emeschi, @cmsbuild, @slava77, @jpata, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mrodozov · 2020-11-11T22:28:07Z

please test for slc7_aarch64_gcc820

cmsbuild · 2020-11-11T22:28:33Z

The tests are being triggered in jenkins.
Test Parameters:

ARCHITECTURE_FILTER = slc7_aarch64_gcc820
CMSSW_11_2_X_2020-11-11-2300/slc7_aarch64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10674/console Started: 2020/11/12 00:42

cmsbuild · 2020-11-11T23:49:09Z

-1

Tested at: 24184d2

CMSSW: CMSSW_11_2_X_2020-11-11-2300
SCRAM_ARCH: slc7_aarch64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373316/10674/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency

Build:

I found compilation error when building:

>> Compiling  /home/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-11-11-2300/src/IOPool/Streamer/src/StreamerInputSource.cc
>> Compiling  /home/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-11-11-2300/src/IOPool/Streamer/src/StreamerOutputFile.cc
>> Compiling  /home/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-11-11-2300/src/IOPool/Streamer/src/StreamerOutputModuleBase.cc
>> Compiling  /home/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-11-11-2300/src/IOPool/Streamer/src/StreamerOutputModuleCommon.cc
In file included from /home/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-11-11-2300/src/IOPool/Streamer/src/FRDEventMessage.cc:12:
/home/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-11-11-2300/src/IOPool/Streamer/interface/FRDEventMessage.h:135:97: error: missing braces around initializer for 'std::__array_traits::_Type' {aka 'unsigned int [7]'} [-Werror=missing-braces]
                                                                               6 * sizeof(uint32)};
                                                                                                 ^
cc1plus: some warnings being treated as errors
In file included from /home/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-11-11-2300/src/IOPool/Streamer/interface/DumpTools.h:11,
                 from /home/cmsbld/jenkins_a/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-11-11-2300/src/IOPool/Streamer/src/DumpTools.cc:5:

cmsbuild · 2020-11-11T23:49:11Z

Comparison job queued.

mrodozov · 2020-11-12T13:32:52Z

please test for slc7_amd64_gcc820

cmsbuild · 2020-11-12T14:41:53Z

-1

Tested at: 8ab76bd

CMSSW: CMSSW_11_2_X_2020-11-11-2300
SCRAM_ARCH: slc7_ppc64le_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373316/10682/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.874 step2

runTheMatrix-results/136.874_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step2_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

136.793 step2

runTheMatrix-results/136.793_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017/step2_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017.log

1306.0 step1

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

312.0 step1

runTheMatrix-results/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO/step1_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO.log

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

1330.0 step1

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step1_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

10042.0 step1

runTheMatrix-results/10042.0_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step1_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

7.3 step1

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step1_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

136.8311 step2

runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

136.88811 step2

runTheMatrix-results/136.88811_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL/step2_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

158.01 step2

runTheMatrix-results/158.01_HydjetQ_reminiaodPbPb2018_INPUT+HydjetQ_reminiaodPbPb2018_INPUT+REMINIAODHI2018PPRECOMB+HARVESTHI2018PPRECOMINIAOD/step2_HydjetQ_reminiaodPbPb2018_INPUT+HydjetQ_reminiaodPbPb2018_INPUT+REMINIAODHI2018PPRECOMB+HARVESTHI2018PPRECOMINIAOD.log

11634.0 step1

runTheMatrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA/step1_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA.log

25202.0 step1

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step1_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

9.0 step1

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

10824.0 step1

runTheMatrix-results/10824.0_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step1_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

25.0 step1

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

12434.0 step1

runTheMatrix-results/12434.0_TTbar_14TeV+2023+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA/step1_TTbar_14TeV+2023+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

10024.0 step1

runTheMatrix-results/10024.0_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step1_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

10224.0 step1

runTheMatrix-results/10224.0_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano/step1_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano.log

250202.181 step1

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step1_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

23434.999 step1

runTheMatrix-results/23434.999_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step1_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

23234.0 step1

runTheMatrix-results/23234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

28234.0 step1

runTheMatrix-results/28234.0_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Thu Nov 12 15:30:40 2020-date Thu Nov 12 15:25:07 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Thu Nov 12 15:26:48 2020-date Thu Nov 12 15:25:08 2020 s - exit: 34816
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu Nov 12 15:30:59 2020-date Thu Nov 12 15:25:12 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:30:59 2020-date Thu Nov 12 15:25:12 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:30:59 2020-date Thu Nov 12 15:25:12 2020 s - exit: 34816
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2018D/EphemeralHLTPhysics1/RAW/v1/000/323/775/00000/2E066536-5CF2-B340-A73B-209640F29FF6.root --customise_commands='if hasattr(process,"simMuonGEMPadTask"): setattr(process,"simMuonGEMPadTask",cms.Task())' : FAILED - time: date Thu Nov 12 15:32:27 2020-date Thu Nov 12 15:25:16 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:32:27 2020-date Thu Nov 12 15:25:16 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:32:27 2020-date Thu Nov 12 15:25:16 2020 s - exit: 34816
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3_pp_on_PbPb --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/data/Run2018D/HIMinimumBias0/RAW/v1/000/325/112/00000/660F62BB-9932-D645-A4A4-0BBBDA3963E8.root --customise_commands='if hasattr(process,"simMuonGEMPadTask"): setattr(process,"simMuonGEMPadTask",cms.Task()); from FWCore.ParameterSet.MassReplace import massSearchReplaceAnyInputTag; massSearchReplaceAnyInputTag(process.SimL1Emulator,"rawDataCollector","rawDataRepacker",False,True)' : FAILED - time: date Thu Nov 12 15:32:44 2020-date Thu Nov 12 15:25:20 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:32:44 2020-date Thu Nov 12 15:25:20 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3_pp_on_PbPb --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:32:44 2020-date Thu Nov 12 15:25:20 2020 s - exit: 34816
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Thu Nov 12 15:40:24 2020-date Thu Nov 12 15:25:24 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:40:24 2020-date Thu Nov 12 15:25:24 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:40:24 2020-date Thu Nov 12 15:25:24 2020 s - exit: 34816
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Thu Nov 12 15:31:10 2020-date Thu Nov 12 15:25:29 2020 s - exit: 34816
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Thu Nov 12 15:35:39 2020-date Thu Nov 12 15:25:33 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:35:39 2020-date Thu Nov 12 15:25:33 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:35:39 2020-date Thu Nov 12 15:25:33 2020 s - exit: 34816
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Thu Nov 12 15:31:12 2020-date Thu Nov 12 15:25:37 2020 s - exit: 34816
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2018D/EphemeralHLTPhysics1/RAW/v1/000/323/775/00000/2E066536-5CF2-B340-A73B-209640F29FF6.root --customise_commands='if hasattr(process,"simMuonGEMPadTask"): setattr(process,"simMuonGEMPadTask",cms.Task())' : FAILED - time: date Thu Nov 12 15:32:03 2020-date Thu Nov 12 15:25:41 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:32:03 2020-date Thu Nov 12 15:25:41 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:32:03 2020-date Thu Nov 12 15:25:41 2020 s - exit: 34816
cmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Thu Nov 12 15:34:37 2020-date Thu Nov 12 15:25:45 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:34:37 2020-date Thu Nov 12 15:25:45 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:34:37 2020-date Thu Nov 12 15:25:45 2020 s - exit: 34816
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3_pp_on_PbPb --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Thu Nov 12 15:37:01 2020-date Thu Nov 12 15:25:49 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:37:01 2020-date Thu Nov 12 15:25:49 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3_pp_on_PbPb --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:37:01 2020-date Thu Nov 12 15:25:49 2020 s - exit: 34816
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_MC.root : FAILED - time: date Thu Nov 12 15:35:21 2020-date Thu Nov 12 15:25:52 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:35:21 2020-date Thu Nov 12 15:25:52 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:35:21 2020-date Thu Nov 12 15:25:52 2020 s - exit: 34816
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Thu Nov 12 15:34:51 2020-date Thu Nov 12 15:25:57 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:34:51 2020-date Thu Nov 12 15:25:57 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:34:51 2020-date Thu Nov 12 15:25:57 2020 s - exit: 34816
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Thu Nov 12 15:31:29 2020-date Thu Nov 12 15:26:04 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:31:29 2020-date Thu Nov 12 15:26:04 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:31:29 2020-date Thu Nov 12 15:26:04 2020 s - exit: 34816
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2018D/EphemeralHLTPhysics1/RAW/v1/000/323/775/00000/2E066536-5CF2-B340-A73B-209640F29FF6.root --customise_commands='if hasattr(process,"simMuonGEMPadTask"): setattr(process,"simMuonGEMPadTask",cms.Task())' : FAILED - time: date Thu Nov 12 15:38:23 2020-date Thu Nov 12 15:26:09 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:38:23 2020-date Thu Nov 12 15:26:09 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:38:23 2020-date Thu Nov 12 15:26:09 2020 s - exit: 34816
cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Thu Nov 12 15:31:35 2020-date Thu Nov 12 15:26:12 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:31:35 2020-date Thu Nov 12 15:26:12 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:31:35 2020-date Thu Nov 12 15:26:12 2020 s - exit: 34816
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Thu Nov 12 15:35:54 2020-date Thu Nov 12 15:26:15 2020 s - exit: 34816
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02654/slc7_ppc64le_gcc820/cms/cmssw/CMSSW_11_2_X_2020-11-11-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Nov 12 15:35:54 2020-date Thu Nov 12 15:26:15 2020 s - exit: 34816
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Nov 12 15:35:54 2020-date Thu Nov 12 15:26:15 2020 s - exit: 34816

cmsbuild · 2020-11-12T14:41:55Z

Comparison job queued.

cmsbuild · 2020-11-12T15:26:48Z

+1
Tested at: 8ab76bd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373316/10689/summary.html
CMSSW: CMSSW_11_2_CLANG_X_2020-11-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-12T15:26:50Z

Comparison job queued.

cmsbuild · 2020-11-12T15:44:20Z

+1
Tested at: 8ab76bd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373316/10692/summary.html
CMSSW: CMSSW_11_2_X_2020-11-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-12T15:44:23Z

Comparison job queued.

cmsbuild · 2020-11-12T17:31:43Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373316/10692/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529296
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2529267
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 148 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-11-12T18:09:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373316/10689/summary.html

Comparison Summary:

You potentially added 5152 lines to the logs
Reco comparison results: 14507 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529296
DQMHistoTests: Total failures: 98310
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 2430962
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
DQMHistoSizes: changed ( 136.793 ): -0.004 KiB JetMET/SUSYDQM
Checked 148 log files, 22 edm output root files, 35 DQM output files

makortel · 2020-11-12T19:01:46Z

+1

perrotta · 2020-11-12T21:45:36Z

+1

Array boundaries fixed as planned
jenkins tests pass

cmsbuild · 2020-11-12T21:46:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-11-13T09:07:34Z

+1

Fix FRD array version check. Version 6 was not added to the version size

1916264

mapping, but was allowed in modules, leading to reading out of boundaries. Hardcoded version is no longer used now except in header where it also defines array size.

cmsbuild added this to the CMSSW_11_2_X milestone Nov 11, 2020

cmsbuild added code-checks-pending comparison-pending core-pending daq-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Nov 11, 2020

smorovic mentioned this pull request Nov 11, 2020

[PPC][ARM] Unit test in EventFilter/Utilities failing #32091

Closed

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 11, 2020

makortel reviewed Nov 11, 2020

View reviewed changes

using constexpr

24184d2

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 11, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 11, 2020

cmsbuild added tests-started and removed tests-pending labels Nov 11, 2020

cmsbuild added tests-rejected and removed tests-started labels Nov 11, 2020

cmsbuild added the tests-started label Nov 12, 2020

cmsbuild added tests-rejected and removed tests-started labels Nov 12, 2020

cmsbuild added tests-approved and removed tests-rejected labels Nov 12, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 12, 2020

cmsbuild added core-approved and removed core-pending labels Nov 12, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Nov 12, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 13, 2020

cmsbuild merged commit 0bef875 into cms-sw:master Nov 13, 2020

smorovic deleted the 112X-fix-frdversion-array branch March 8, 2021 20:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAQ: fix FedRawData source going out of array boundaries #32116

DAQ: fix FedRawData source going out of array boundaries #32116

smorovic commented Nov 11, 2020 •

edited

cmsbuild commented Nov 11, 2020

makortel Nov 11, 2020

smorovic Nov 11, 2020

cmsbuild commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

mrodozov commented Nov 11, 2020

cmsbuild commented Nov 11, 2020 •

edited

cmsbuild commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

mrodozov commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

makortel commented Nov 12, 2020

perrotta commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

silviodonato commented Nov 13, 2020

		const size_t FRDHeaderMaxVersion = 6;
		const std::array<uint32,FRDHeaderMaxVersion+1> FRDHeaderVersionSize = {

DAQ: fix FedRawData source going out of array boundaries #32116

DAQ: fix FedRawData source going out of array boundaries #32116

Conversation

smorovic commented Nov 11, 2020 • edited

PR description:

PR validation:

cmsbuild commented Nov 11, 2020

makortel Nov 11, 2020

Choose a reason for hiding this comment

smorovic Nov 11, 2020

Choose a reason for hiding this comment

cmsbuild commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

mrodozov commented Nov 11, 2020

cmsbuild commented Nov 11, 2020 • edited

cmsbuild commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

mrodozov commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

makortel commented Nov 12, 2020

perrotta commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

silviodonato commented Nov 13, 2020

smorovic commented Nov 11, 2020 •

edited

cmsbuild commented Nov 11, 2020 •

edited