Run3-sim75 Remove namespace for comparison in SD classes

[bsunanda]

PR description:

Remove namespace for comparison in SD classes. DDD removes namespace while passing on the name to Geant4 while DD4Hep does not. So comparison of names is better done after removing namespace.

PR validation:

Tested using workflows in the test areas of SimG4Core/Configuration/test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32201/19940

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32201/19940/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32201/19940/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32201/19941

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/EcalSimData
SimG4CMS/Calo

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @rovere, @argiro, @makortel, @thomreis, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32201/19963

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #32201 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-19-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10908/console Started: 2020/11/20 17:20

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99f567/10908/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3509 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2962300
• DQMHistoTests: Total failures: 8447
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2953831
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[cvuosalo]

@bsunanda In the PR description, please provide some explanation for making this change.

[civanch]

@bsunanda , you left DEBUG for purpose or forget?

[bsunanda]

I left it on purpose. I am working on a PR after this where I need to change this class as well. That will provide a true comparison between ddd and dd4hep. Could you sign this PR?

[bsunanda]

@cvuosalo Could you sign this PR? I have one more PR after this gets integrated

[bsunanda]

@cvuosalo @civanch Please approve this PR

[cvuosalo]

Do we know why there are 3509 comparison differences in the DD4hep workflows?

[bsunanda]

Earlier the material dependent corrections were wrong. So this is indeed a bug correction

[civanch]

@bsunanda , you left "#define EDM_ML_DEBUG" uncommented. Is it what should be?

[bsunanda]

I shall correct in the next PR. Please let this PR be merged

…

________________________________ From: Vladimir Ivantchenko [notifications@github.com] Sent: 23 November 2020 22:38 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-sim75 Remove namespace for comparison in SD classes (#32201) @bsunanda<https://github.com/bsunanda> , you left "#define EDM_ML_DEBUG" uncommented. Is it what should be? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#32201 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOWKXWRC7BVEEXBJGYLSRLI4HANCNFSM4T4DEPGA>.

[cvuosalo]

+1

[bsunanda]

@civanch I need your signature

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1
@bsunanda please prepare a PR to close the edm_debug as soon as possible. We will build 11_2_0_pre10 tomorrow

[bsunanda]

@silviodonato Waiting for the IB with this PR to submit my next one