-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to ESconsumes GeantPropagatorESProducer #32260
migrate to ESconsumes GeantPropagatorESProducer #32260
Conversation
@makortel @Dr15Jones would be so kind to take a look to what is the problem here?
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32260/20026
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: TrackPropagation/Geant4e @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
ce68764
to
9efa291
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32260/20033
|
Pull request #32260 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
If I understand correctly the ESConsumes migration is done correctly and once that is fixed, this uncovers a further problem with Geant4e which is not seen in 10.6.x. Any further help is appreciated since until this is fixed we cannot close issue #31920 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@mmusich , for me this G4Refitter.py is working for 10_6_X and fails in 11_2_X in a different way. Your crash means, that Geant4 geometry is not built in 11_2, my crash is different but the reason is similar. This is not Geant4e issue but this is the issue how Geant4 geometry is instantiated in 11_2 - we changed this place, when prepared migration to DD4Hep. Corresponding modifications should be propagated to G4Refitter.py for 11_2. What I miss - how G4Refitter.py is created? |
+1 |
Please let me know how it should be modified. Thanks |
PR description:
This PR is an attempt to solve the issue reported at #31920 (comment)
Running the following test configuration in
CMSSW_11_2_X_2020-11-23-2300
results in:PR validation:
Tested with the configuration linked above, unfortunately resulting into a segmentation fault.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, no backport needed.