Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New jet flavour definition: Pruned GenParticles update #3228

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Apr 5, 2014

Minor update to the new jet flavour code that fixes the parton selection routines when pruned GenParticles are used instead of the full GenParticle collection. Does not change DataFormats and has no impact on the standard reconstruction.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2014

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_1_X.

New jet flavour definition: Pruned GenParticles update

It involves the following packages:

PhysicsTools/JetExamples
PhysicsTools/JetMCAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Apr 8, 2014

+1

On Sun, Apr 6, 2014 at 8:18 AM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @ferencek https://github.com/ferencek(Dinko Ferencek) for CMSSW_7_1_X.

New jet flavour definition: Pruned GenParticles update

It involves the following packages:

PhysicsTools/JetExamples
PhysicsTools/JetMCAlgos

@nclopezo https://github.com/nclopezo, @vadlerhttps://github.com/vadler,
@cmsbuild https://github.com/cmsbuild, @deganohttps://github.com/degano,
@monttj https://github.com/monttj can you please review it and
eventually sign? Thanks.
@pvmulder https://github.com/pvmulder this is something you requested
to watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@nclopezo https://github.com/nclopezo, @ktf https://github.com/ktfyou are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.

Reply to this email directly or view it on GitHubhttps://github.com//pull/3228#issuecomment-39653886
.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 8, 2014
…iclesUpdate_from-CMSSW_7_1_X_2014-04-05-1400

AT -- New jet flavour definition: Pruned GenParticles update
@ktf ktf merged commit 007d0be into cms-sw:CMSSW_7_1_X Apr 8, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants