Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New jet flavour definition: Backport from 7_1_X to 7_0_X #3256

Merged

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Apr 8, 2014

Backport of #2395, #3025, and #3228.

Update (Apr. 30, 2014): PR rebased (to avoid conflicts with #3254) and extended by also backporting #3509 (integrates the new jet flavor into PAT) and #3601 (changes the data members of pat::Jet storing the flavor information)

Update (May 9, 2014): PR extended by also backporting #3785 which replaces runtime cms::Exception calls with edm::LogError calls in the jet flavour code

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2014

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_0_X.

New jet flavour definition: Backport from 7_1_X

It involves the following packages:

PhysicsTools/JetExamples
PhysicsTools/JetMCAlgos
PhysicsTools/JetMCUtils
SimDataFormats/JetMatching

@civanch, @nclopezo, @mdhildreth, @monttj, @cmsbuild, @vadler, @Degano can you please review it and eventually sign? Thanks.
@pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

@ferencek ferencek changed the title New jet flavour definition: Backport from 7_1_X New jet flavour definition: Backport from 7_1_X to 7_0_X Apr 9, 2014
@vadler
Copy link

vadler commented Apr 11, 2014

+1

@cmsbuild
Copy link
Contributor

Pull request #3256 was updated. @civanch, @nclopezo, @mdhildreth, @monttj, @cmsbuild, @vadler, @Degano can you please check and sign again.

@vadler
Copy link

vadler commented May 12, 2014

+1

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented May 13, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request May 13, 2014
New jet flavour definition: Backport from 7_1_X to 7_0_X
@davidlange6 davidlange6 merged commit 7e9702d into cms-sw:CMSSW_7_0_X May 13, 2014
@ferencek ferencek deleted the NewJetFlavour_from-CMSSW_7_0_1 branch May 13, 2014 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants