Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex40 Add scenarios with modified tracker material budgets for the Run3 scenario #32300

Merged
merged 1 commit into from Dec 1, 2020

Conversation

bsunanda
Copy link
Contributor

PR description:

Add 4 scenarios with modified tracker material budgets (changed by +-5% or +-10%) for the Run3 scenario

PR validation:

Tested using a cfg file in Geometry/CMSCommonData/test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32300/20119

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Configuration/Geometry
Configuration/StandardSequences
Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @kpedro88, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2020

The tests are being triggered in jenkins.

@civanch
Copy link
Contributor

civanch commented Nov 26, 2020

@bsunanda , this one may be not needed in 11_2? what you think?

@bsunanda
Copy link
Contributor Author

@civanch I also think it need not be back ported to 11_2_X. It is needed for Run3 data analysis which may be 11_3 or other future version

@cmsbuild
Copy link
Contributor

+1
Tested at: b5c6639
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea811/11075/summary.html
CMSSW: CMSSW_11_2_X_2020-11-25-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ea811/11075/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747014
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2746991
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 34 edm output root files, 36 DQM output files

@kpedro88
Copy link
Contributor

+upgrade

@cvuosalo
Copy link
Contributor

@bsunanda Is there still another PR required to create the 5/10% scenarios? I think DB loader scripts still need to be made.

@bsunanda
Copy link
Contributor Author

@cvuosalo Yes - but that PR should be made after integrating this. Could you please approve this PR?

@cvuosalo
Copy link
Contributor

+1

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 1, 2020

@silviodonato @qliphy Can this PR be integrated?

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants