Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticleLevelProducer: check for leptonic decays of tag particles #32310

Merged
merged 2 commits into from Nov 30, 2020

Conversation

mseidel42
Copy link
Contributor

PR description:

Adds lepton+neutrino daughters of jet tag particles (heavy hadrons) to allow for calculation and correction of semileptonic branching ratios.

PR validation:

Output is as expected:

root [3] Events->Scan("recoGenParticles_particleLevel_tags_TQAF.obj.m_state.pdgId_")
***********************************
*    Row   * Instance * recoGenPa *
***********************************
*        0 *        0 *       421 *
*        0 *        1 *      -421 *
*        0 *        2 *       521 *
*        0 *        3 *       431 * <-- this one decays leptonically
*        0 *        4 *       -13 * <-- decay product
*        0 *        5 *        14 * <-- decay product

Validated by @swertz to recover the Pythia 8 input BRs of B hadrons:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32310/20130

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @intrepid42 (Markus Seidel) for master.

It involves the following packages:

GeneratorInterface/RivetInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Nov 27, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: b76cce8

CMSSW: CMSSW_11_3_X_2020-11-26-2300
SCRAM_ARCH: slc7_amd64_gcc900
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e288e/11099/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
11624.911 step1

runTheMatrix-results/11624.911_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA/step1_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: b76cce8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e288e/11138/summary.html
CMSSW: CMSSW_11_3_X_2020-11-28-1100
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e288e/11138/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529570
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 34 edm output root files, 35 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Nov 29, 2020

@cms-sw/generators-l2 Can you have a look and sign?

@SiewYan
Copy link
Contributor

SiewYan commented Nov 30, 2020

Hi, its look good to me.

@SiewYan
Copy link
Contributor

SiewYan commented Nov 30, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants