Clean some more BuildFiles

[guitargeek]

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #32030).

This PR deals with some BuildFiles that were not processed by the BuildFile cleaning script so far and revisits some BuildFiles in the reco area that can be cleaned further after #32266.

As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32324/20155

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CalibTracker/SiStripLorentzAngle
DQM/SiOuterTracker
DataFormats/L1THGCal
L1Trigger/L1THGCal
L1Trigger/L1THGCalUtilities
RecoBTag/ONNXRuntime
RecoEgamma/EgammaPhotonProducers

@perrotta, @andrius-k, @yuanchao, @kmaeshima, @slava77, @christopheralanwest, @ErnestaP, @tocheng, @jmduarte, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @tlampen, @jpata, @pohsun, @kpedro88 can you please review it and eventually sign? Thanks.
@echabert, @emilbols, @jainshilpi, @pieterdavid, @robervalwalsh, @Martin-Grunewald, @jbsauvan, @varuns23, @smoortga, @lgray, @ferencek, @Sam-Harper, @sroychow, @tocheng, @rovere, @mmusich, @arossi83, @gbenelli, @JyothsnaKomaragiri, @sobhatta, @lecriste, @afiqaize, @andrzejnovak, @amarini, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_3_X_2020-11-29-0000/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11142/console Started: 2020/11/29 15:11

[cmsbuild]

+1
Tested at: 02978ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb08e3/11142/summary.html
CMSSW: CMSSW_11_3_X_2020-11-29-0000
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb08e3/11142/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2529564
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 148 log files, 34 edm output root files, 35 DQM output files

[jfernan2]

+1

[kpedro88]

Are the changes in recoConversions for the Phase 2 D49 workflow caused by this PR?

[jpata]

good catch, it does seem like that, since this PR was the only one in the test?

[kpedro88]

An alternative could be some inherent instability (uninitialized memory etc.), but I haven't observed that before for these particular plots.

[guitargeek]

I don't think this PR responsible for that. The differences are apparent in many PRs right now, e.g.:
#32326
#32327

[kpedro88]

thanks for checking @guitargeek - I opened #32338 to track this problem

[kpedro88]

+upgrade

[jpata]

+reconstruction

• technical, removes unneeded imports in a few BuildFiles (and rearranges in CalibTracker/SiStripLorentzAngle)
• no reco changes as expected (only irrelevant ones in 23434.0)

[silviodonato]

kind reminder
@cms-sw/alca-l2 @cms-sw/l1-l2

[silviodonato]

kind reminder
@cms-sw/alca-l2 @cms-sw/l1-l2

[yuanchao]

+1

• modifications only on BuildFiles, no compiling error caused
• matrix tests and unit tests passed

[guitargeek]

Hi @rekovic, is this okay for L1?

[silviodonato]

merge
@cms-sw/l1-l2 please let us know