Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean some more BuildFiles #32570

Merged
merged 1 commit into from Dec 30, 2020
Merged

Clean some more BuildFiles #32570

merged 1 commit into from Dec 30, 2020

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #32324).

As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32570/20551

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CommonTools/MVAUtils
CommonTools/RecoAlgos
DQM/SiPixelMonitorCluster
DQM/SiPixelMonitorTrack
EventFilter/HcalRawToDigi
PhysicsTools/NanoAOD
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/Examples
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
SimCalorimetry/HGCalSimProducers
SimDataFormats/Associations
SimG4Core/Application
Validation/SiPixelPhase1TrackClustersV

@perrotta, @andrius-k, @gouskos, @kmaeshima, @civanch, @ErnestaP, @mdhildreth, @cmsbuild, @jfernan2, @fgolf, @fioriNTU, @slava77, @jpata, @mariadalfonso, @santocch, @kpedro88 can you please review it and eventually sign? Thanks.
@rappoccio, @jainshilpi, @jandrea, @argiro, @Martin-Grunewald, @pfs, @thomreis, @lgray, @abbiendi, @peruzzim, @slomeo, @sethzenz, @jdolen, @makortel, @threus, @jhgoh, @varuns23, @apsallid, @fioriNTU, @vandreev11, @Sam-Harper, @sroychow, @rovere, @cseez, @gkasieczka, @hatakeyamak, @idebruyn, @abdoulline, @fabiocos, @clelange, @arossi83, @hdelanno, @swertz, @rchatter, @ahinzmann, @sobhatta, @lecriste, @afiqaize, @gpetruc, @mariadalfonso, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5710db/11835/summary.html
CMSSW: CMSSW_11_3_X_2020-12-22-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716941
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

+upgrade

@civanch
Copy link
Contributor

civanch commented Dec 25, 2020

+1

@perrotta
Copy link
Contributor

+1

  • Technical, it looks correct
  • Jenkins tests pass

@santocch
Copy link

+1

@guitargeek
Copy link
Contributor Author

@mariadalfonso, can you sign this off? Thanks!

@mariadalfonso
Copy link
Contributor

+xpog

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 30, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants