Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporarily ctppsProtons from recoCTPPSTask (Run-3 only, 11_2_X backport) #32346

Merged
merged 1 commit into from Dec 1, 2020

Conversation

silviodonato
Copy link
Contributor

@silviodonato silviodonato commented Dec 1, 2020

PR description:

We need a new global tag to solve #32340. This PR temporarily removes ctppsProtons from recoCTPPSTask to move on the validation of CMSSW_11_2_0_pre10, if the preparation of the new global tag will take too much time.

PR validation:

cmsDriver.py step3 --conditions auto:phase1_2021_realistic -s RAW2DIGI,L1Reco,RECO,RECOSIM,EI,PAT,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO -n 10 --geometry DB:Extended --era Run3 --eventcontent RECOSIM,MINIAODSIM,DQM --filein file:/afs/cern.ch/user/s/sdonato/ORPlxplus/CMSSW_11_2_0_pre10/src/debug_PPS/badd237c-4857-4f48-b10f-52c832f57f02_ev1126.root (see #32340.)

backport of #32352

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_11_2_X.

It involves the following packages:

RecoPPS/Configuration

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jan-kaspar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

The tests are being triggered in jenkins.

@silviodonato
Copy link
Contributor Author

hold
#32340 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

+1
Tested at: 73df2a7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cc351/11197/summary.html
CMSSW: CMSSW_11_2_X_2020-11-30-2300
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

@silviodonato
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label Dec 1, 2020
@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

The tests are being triggered in jenkins.

@silviodonato
Copy link
Contributor Author

backport of #32352

@silviodonato silviodonato changed the title Remove temporarily ctppsProtons from recoCTPPSTask Remove temporarily ctppsProtons from recoCTPPSTask (Run-3 only, 11_2_X backport) Dec 1, 2020
@silviodonato
Copy link
Contributor Author

urgent
to unblock the Run-3 RelVals of CMSSW_11_2_0_pre10 (see #32340)

@cmsbuild cmsbuild added the urgent label Dec 1, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

+1
Tested at: 40ed42d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cc351/11209/summary.html
CMSSW: CMSSW_11_2_X_2020-11-30-2300
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cc351/11209/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529564
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 34 edm output root files, 35 DQM output files

@slava77
Copy link
Contributor

slava77 commented Dec 1, 2020

+1

for #32346 40ed42d

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit 484cc92 into cms-sw:CMSSW_11_2_X Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants